Skip to content

test: remove unreachable return - #46807

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:remove-unreachable-code
Feb 25, 2023
Merged

test: remove unreachable return#46807
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:remove-unreachable-code

Conversation

@jakecastelli

@jakecastellijakecastelli commented Feb 24, 2023

Copy link
Copy Markdown
Member

Found unreachable return in the tests while looking into test/abort.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 24, 2023
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49984/

@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 24, 2023
@lpincalpinca added fast-track PRs that do not need to wait for 48 hours to land. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 24, 2023
@github-actions

github-actionsBot commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/49989/

@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 69a0d8b into nodejs:mainFeb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 69a0d8b

targos pushed a commit that referenced this pull request Mar 13, 2023
@jakecastelli@targos
test: remove unreachable return
e52ad92
PR-URL: #46807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@jakecastelli@danielleadams
test: remove unreachable return
bb18246
PR-URL: #46807
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jakecastelli@nodejs-github-bot@jasnell@Trott@lpinca@cjihrig@debadree25