Skip to content

debugger: Add set context line number command - #46812

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
Dailyscat:add_setContextLineNumber_command
Mar 12, 2023
Merged

debugger: Add set context line number command#46812
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
Dailyscat:add_setContextLineNumber_command

Conversation

@Dailyscat

@DailyscatDailyscat commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

related: #41788

@nodejs-github-botnodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Feb 24, 2023
@Dailyscat
Dailyscatforce-pushed the add_setContextLineNumber_command branch from 8440c77 to 9fff60eCompareFebruary 24, 2023 10:18
@cola119

cola119 commented Feb 24, 2023

Copy link
Copy Markdown
Member

@Dailyscat Great work! Changes look fine to me but can you do the chores before review?

  1. Can you update the commit message to conform to the guideline? The subsystem in this change is debugger, so debugger: add a command to set which lines to check for context is a good message.
  2. Can you run the linter make lint-js-fix?

@Dailyscat
Dailyscatforce-pushed the add_setContextLineNumber_command branch from 9fff60e to 4043dd4CompareFebruary 24, 2023 15:58
@Dailyscat
Dailyscatforce-pushed the add_setContextLineNumber_command branch 2 times, most recently from a5f311b to 6542213CompareFebruary 24, 2023 16:09
@Dailyscat

Dailyscat commented Feb 24, 2023

Copy link
Copy Markdown
ContributorAuthor

@Dailyscat Great work! Changes look fine to me but can you do the chores before review?

  1. Can you update the commit message to conform to the guideline? The subsystem in this change is debugger, so debugger: add a command to set which lines to check for context is a good message.
  2. Can you run the linter make lint-js-fix?

Oh I missed that part, fixed it, thanks!

@DailyscatDailyscat changed the title repl: Add set context line number commanddebugger: Add set context line number commandFeb 25, 2023
@cola119cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50042/

@github-actionsgithub-actionsBot mentioned this pull request Feb 28, 2023
Open
16 tasks
@Dailyscat
Dailyscatforce-pushed the add_setContextLineNumber_command branch from 6542213 to 730ad86CompareFebruary 28, 2023 06:43
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50086/

@github-actionsgithub-actionsBot mentioned this pull request Mar 1, 2023
Open
15 tasks
cola119
cola119 reviewed Mar 1, 2023
View reviewed changes
Comment threadlib/internal/debugger/inspect_repl.js
Comment threadlib/internal/debugger/inspect_repl.js Outdated
Comment threadtest/fixtures/debugger/twenty-lines.js Outdated
Comment threadtest/sequential/test-debugger-set-context-line-number.mjs Outdated
@github-actionsgithub-actionsBot mentioned this pull request Mar 2, 2023
Open
15 tasks
@Dailyscat

Dailyscat commented Mar 2, 2023

Copy link
Copy Markdown
ContributorAuthor

@cola119 san I applied a review. please check it!

cola119
cola119 reviewed Mar 2, 2023
View reviewed changes
Comment threadlib/internal/debugger/inspect_repl.js Outdated
@github-actionsgithub-actionsBot mentioned this pull request Mar 3, 2023
Open
18 tasks
@cola119cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50180/

@cola119cola119 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 7, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 7, 2023
This was referenced Mar 8, 2023
Open
Open
@cola119cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50284/

@github-actionsgithub-actionsBot mentioned this pull request Mar 10, 2023
Open
22 tasks
@cola119cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023
@github-actionsgithub-actionsBot mentioned this pull request Mar 11, 2023
Open
22 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50320/

@github-actionsgithub-actionsBot mentioned this pull request Mar 12, 2023
Open
20 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50325/

@cola119cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 7f2ab4e into nodejs:mainMar 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 7f2ab4e

@github-actionsgithub-actionsBot mentioned this pull request Mar 13, 2023
Open
20 tasks
targos pushed a commit that referenced this pull request Mar 13, 2023
@Dailyscat@targos
debugger: add a command to set which lines to check for context
227629e
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actionsgithub-actionsBot mentioned this pull request Mar 14, 2023
Open
24 tasks
targos pushed a commit that referenced this pull request Mar 14, 2023
@Dailyscat@targos
debugger: add a command to set which lines to check for context
afbd818
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
This was referenced Mar 15, 2023
Open
Open
Open
@cola119cola119 mentioned this pull request Mar 26, 2023
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@Dailyscat@danielleadams
debugger: add a command to set which lines to check for context
51253ba
PR-URL: #46812
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cola119cola119cola119 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.debuggerIssues and PRs related to the debugger subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dailyscat@cola119@nodejs-github-bot