Skip to content

tools: fix linter message when using global DOMException - #46822

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:dom-exception-linter-error
Feb 26, 2023
Merged

tools: fix linter message when using global DOMException#46822
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:dom-exception-linter-error

Conversation

@aduh95

@aduh95aduh95 commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

Refs:

node/lib/internal/util.js

Lines 601 to 610 in 757c104

let_DOMException;
constlazyDOMExceptionClass=()=>{
_DOMException??=internalBinding('messaging').DOMException;
return_DOMException;
};
constlazyDOMException=hideStackFrames((message,name)=>{
_DOMException??=internalBinding('messaging').DOMException;
returnnew_DOMException(message,name);
});

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Feb 24, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Feb 24, 2023
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@aduh95aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 26, 2023
@aduh95
aduh95 merged commit 55dd283 into nodejs:mainFeb 26, 2023
@aduh95

aduh95 commented Feb 26, 2023

Copy link
Copy Markdown
ContributorAuthor

Landed in 55dd283

@aduh95
aduh95 deleted the dom-exception-linter-error branch February 26, 2023 17:44
targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95@targos
tools: fix linter message when using global DOMException
ffcd301
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95@targos
tools: fix linter message when using global DOMException
f558797
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95@danielleadams
tools: fix linter message when using global DOMException
fff3186
Refs: https://github.com/nodejs/node/blob/757c10414776b6f035ced453599527a841f47d6e/lib/internal/util.js#L601-L610
PR-URL: #46822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+2 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aduh95@apapirovski@jasnell@cjihrig@debadree25@ZYSzys@nodejs-github-bot