Skip to content

lib,src: fix a few typos in comments - #46835

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:lib-src-just-some-typos
Feb 25, 2023
Merged

lib,src: fix a few typos in comments#46835
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:lib-src-just-some-typos

Conversation

@tniessen

@tniessentniessen commented Feb 25, 2023

Copy link
Copy Markdown
Member

Nothing exciting here.

@tniessentniessen added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@tniessentniessen added the lib / src Issues and PRs related to general changes in the lib or src directory. label Feb 25, 2023
@github-actions

github-actionsBot commented Feb 25, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 25, 2023
@tniessentniessen removed the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 25, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50000/

@tniessentniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 25, 2023
@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0f10c87 into nodejs:mainFeb 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0f10c87

targos pushed a commit that referenced this pull request Mar 13, 2023
@tniessen@targos
lib,src: fix a few typos in comments
1a97c4b
PR-URL: #46835
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@tniessen@targos
lib,src: fix a few typos in comments
345c8c3
PR-URL: #46835
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@tniessen@danielleadams
lib,src: fix a few typos in comments
7f9e60a
PR-URL: #46835
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@richardlaurichardlaurichardlau approved these changes
@MoLowMoLowMoLow approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tniessen@nodejs-github-bot@Trott@richardlau@MoLow@marco-ippolito@VoltrexKeyva