Skip to content

meta: remove AUTHORS file - #46845

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:rm-authors
Feb 28, 2023
Merged

meta: remove AUTHORS file#46845
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Trott:rm-authors

Conversation

@Trott

@TrottTrott commented Feb 26, 2023

Copy link
Copy Markdown
Member

The AUTHORS file does not serve any significant practical purpose and is a bit of a maintenance annoyance. Let's remove it.

@Trott
meta: remove AUTHORS file
9b2e2c4
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.
@nodejs-github-bot

nodejs-github-bot commented Feb 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Feb 26, 2023
@Trott

Trott commented Feb 26, 2023

Copy link
Copy Markdown
MemberAuthor

A modest proposal.....

@aduh95

aduh95 commented Feb 26, 2023

Copy link
Copy Markdown
Contributor

A reason to keep it would be that it seems to help keeping the mailmap up-to-date, which is convenient (but is that worth the maintenance burden? I'm not sure, happy to leave that decision to others).

@Trott
Trott marked this pull request as ready for review February 26, 2023 18:29
@TrottTrott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 26, 2023
mcollina
mcollina approved these changes Feb 27, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bnb
bnb approved these changes Feb 27, 2023
View reviewed changes
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a76cb23 into nodejs:mainFeb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in a76cb23

@Trott
Trott deleted the rm-authors branch March 1, 2023 01:06
targos pushed a commit that referenced this pull request Mar 13, 2023
@Trott@targos
meta: remove AUTHORS file
8934044
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.
PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@Trott@targos
meta: remove AUTHORS file
b199acd
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.
PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Mar 14, 2023
Merged
Closed
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@Trott@danielleadams
meta: remove AUTHORS file
abe1488
The AUTHORS file does not serve any significant practical purpose and is
a bit of a maintenance annoyance. Let's remove it.
PR-URL: #46845
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
blair added a commit to macports/macports-ports that referenced this pull request Apr 13, 2023
@blair
nodejs18: update to version 18.16.0
5346215
Do not install AUTHORS as it was removed upstream [1][2].
[1] nodejs/node#46845
[2] nodejs/node@abe1488f86
@marco-ippolitomarco-ippolito mentioned this pull request May 12, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@bnoordhuisbnoordhuisbnoordhuis approved these changes
@bnbbnbbnb approved these changes
@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@ronagronagronag approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@trivikrtrivikrtrivikr approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+3 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@LinkgoronLinkgoronLinkgoron approved these changes
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@Trott@nodejs-github-bot@aduh95@apapirovski@mcollina@bnoordhuis@bnb@Linkgoron@lpinca@targos@ronag@gengjiawen@UlisesGascon@BethGriggs@trivikr@RafaelGSS@RaisinTen@VoltrexKeyva