Skip to content

test: fix test file path in test-permission-deny-fs-symlink-target-write.js - #46859

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
LiviaMedeiros:test-fix-permdenysymwrite-pollution
Mar 1, 2023
Merged

test: fix test file path in test-permission-deny-fs-symlink-target-write.js#46859
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
LiviaMedeiros:test-fix-permdenysymwrite-pollution

Conversation

@LiviaMedeiros

@LiviaMedeirosLiviaMedeiros commented Feb 27, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This test creates file with some content in current working directory. Let's move it to tmpdir.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 27, 2023
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50053/

aduh95
aduh95 reviewed Feb 27, 2023
View reviewed changes
Comment threadtest/parallel/test-permission-deny-fs-symlink-target-write.js Outdated
@LiviaMedeiros@aduh95
squash: Update test/parallel/test-permission-deny-fs-symlink-target-w…
46c68a2
…rite.js
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@LiviaMedeirosLiviaMedeiros added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Feb 28, 2023
@LiviaMedeirosLiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@LiviaMedeirosLiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 28, 2023
@anonrig

anonrig commented Feb 28, 2023

Copy link
Copy Markdown
Member

Can we fast-track this? It isn't very pleasant at the moment.

@LiviaMedeirosLiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 28, 2023
@github-actions

github-actionsBot commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

@LiviaMedeiros

LiviaMedeiros commented Feb 28, 2023

Copy link
Copy Markdown
MemberAuthor

Yes, fast-track would be great.

For clarification: this test creates file with some content in current working directory.

@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50106/

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50108/

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46859
✔ Done loading data for nodejs/node/pull/46859
----------------------------------- PR info ------------------------------------
Title test: fix test file path in `test-permission-deny-fs-symlink-target-write.js` (#46859)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch LiviaMedeiros:test-fix-permdenysymwrite-pollution -> nodejs:main
Labels test, fast-track, author ready, needs-ci, commit-queue-squash
Commits 3
- test: fix file path in permission symlink test
- squash: Update test/parallel/test-permission-deny-fs-symlink-target-w…
- squash: fixup
Committers 2
- LiviaMedeiros - GitHub PR-URL: https://github.com/nodejs/node/pull/46859
Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46859
Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 27 Feb 2023 10:20:16 GMT
✔ Approvals: 2
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317516821
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317760108
ℹ This PR is being fast-tracked
✖ The fast-track request requires at least two collaborators' approvals (👍).
✖ Last GitHub CI failed
ℹ Last Full PR CI on 2023-02-28T15:21:19Z: https://ci.nodejs.org/job/node-test-pull-request/50106/
- Querying data for job/node-test-pull-request/50106/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4294881377

@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50109/

@LiviaMedeirosLiviaMedeiros added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 28, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Feb 28, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46859
✔ Done loading data for nodejs/node/pull/46859
----------------------------------- PR info ------------------------------------
Title test: fix test file path in `test-permission-deny-fs-symlink-target-write.js` (#46859)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch LiviaMedeiros:test-fix-permdenysymwrite-pollution -> nodejs:main
Labels test, fast-track, author ready, needs-ci, commit-queue-squash
Commits 3
- test: fix file path in permission symlink test
- squash: Update test/parallel/test-permission-deny-fs-symlink-target-w…
- squash: fixup
Committers 2
- LiviaMedeiros - GitHub PR-URL: https://github.com/nodejs/node/pull/46859
Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46859
Reviewed-By: Antoine du Hamel Reviewed-By: Yagiz Nizipli --------------------------------------------------------------------------------
ℹ This PR was created on Mon, 27 Feb 2023 10:20:16 GMT
✔ Approvals: 2
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317516821
✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/46859#pullrequestreview-1317760108
ℹ This PR is being fast-tracked
✖ The fast-track request requires at least two collaborators' approvals (👍).
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-02-28T16:44:09Z: https://ci.nodejs.org/job/node-test-pull-request/50109/
- Querying data for job/node-test-pull-request/50109/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4295652013

@LiviaMedeirosLiviaMedeiros added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 1, 2023
@aduh95aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Mar 1, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4a7c3e9 into nodejs:mainMar 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4a7c3e9

@LiviaMedeiros

This comment was marked as resolved.

Sign in to view
This was referenced Mar 3, 2023
Open
Open
targos pushed a commit that referenced this pull request Mar 13, 2023
@LiviaMedeiros@targos
test: fix file path in permission symlink test
cf745c5
PR-URL: #46859
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LiviaMedeiros@nodejs-github-bot@anonrig@aduh95@targos@RafaelGSS