Skip to content

url: remove unnecessary call to FunctionPrototypeBind - #46870

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:remove-unused-bind
Mar 1, 2023
Merged

url: remove unnecessary call to FunctionPrototypeBind#46870
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:remove-unused-bind

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

No description provided.

@aduh95
aduh95 requested a review from anonrigFebruary 27, 2023 20:40
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 27, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 27, 2023
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 27, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 928a2b0 into nodejs:mainMar 1, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 928a2b0

@aduh95
aduh95 deleted the remove-unused-bind branch March 1, 2023 21:08
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46870
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46870
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #46870
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@nodejs-github-bot@jasnell@lpinca@TimothyGu@anonrig@cjihrig@BridgeAR