repl: preserve preview on ESCAPE key press by meixg · Pull Request #46878 · nodejs/node

meixg · 2023-02-28T09:33:32Z

nodejs-github-bot · 2023-02-28T10:16:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50092/

BridgeAR

This seems like a nice improvement!
I would just not negate the argument and use an if statement.

BridgeAR

I just noticed that this might require a bit more work: in case the line completion and the preview is active, it should remove both.

nodejs-github-bot · 2023-02-28T10:58:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50094/

meixg · 2023-02-28T11:04:15Z

I just noticed that this might require a bit more work: in case the line completion and the preview is active, it should remove both.

Do you mean:

> let someStr = '123'
undefined
> '0' + someStr // <- '0' + som
'0123'

then press escape ? I tried and it will remove both.

> let someStr = '123'
undefined
> '0' + som

BridgeAR · 2023-02-28T11:11:24Z

@meixg yes, that's what I meant. I just saw that it will work as expected due to resetting the preview suffix to null and therefore not having a match anymore. Good work!

nodejs-github-bot · 2023-03-01T01:53:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50116/

nodejs-github-bot · 2023-03-03T03:21:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50177/

Fix: nodejs#46876

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot · 2023-03-03T04:01:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50178/

nodejs-github-bot · 2023-03-05T13:37:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50209/

nodejs-github-bot · 2023-03-06T01:40:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50218/

change according to cr

nodejs-github-bot · 2023-03-11T08:49:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50317/

nodejs-github-bot · 2023-03-11T15:10:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50321/

nodejs-github-bot · 2023-03-13T09:17:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50351/

nodejs-github-bot · 2023-03-14T10:13:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50374/

nodejs-github-bot · 2023-03-14T14:02:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/50378/

BridgeAR

Still LGTM

nodejs-github-bot · 2023-03-16T03:24:26Z

Landed in 2566400

Fix: #46876 PR-URL: #46878Fixes: #46876 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Feb 28, 2023

meixg force-pushed the repl-escape-preview branch from 21dc2b9 to 61416f4Compare February 28, 2023 10:08

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023

meixg force-pushed the repl-escape-preview branch from 61416f4 to d636ce8Compare February 28, 2023 10:16

BridgeAR reviewed Feb 28, 2023
View reviewed changes

Comment threadlib/internal/repl/utils.js Outdated
Comment threadlib/internal/repl/utils.js Outdated
Comment threadlib/repl.js Outdated

BridgeAR approved these changes Feb 28, 2023
View reviewed changes

Comment threadlib/internal/repl/utils.js Outdated

BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023

BridgeAR reviewed Feb 28, 2023
View reviewed changes

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 28, 2023

github-actionsBot mentioned this pull request Mar 1, 2023
CI Reliability 2023-03-01 nodejs/reliability#510
Open
15 tasks

This was referenced Mar 2, 2023
CI Reliability 2023-03-02 nodejs/reliability#511
Open
CI Reliability 2023-03-03 nodejs/reliability#512
Open

meixgand others added 2 commits March 3, 2023 11:25

repl: preserve preview on ESCAPE key press
90c08fe
Fix: nodejs#46876

Change noCompletion to showCompletion
3ede267
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

meixg force-pushed the repl-escape-preview branch from 7eef4d7 to 24cec13Compare March 3, 2023 03:26

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 3, 2023

repl: preserve preview on ESCAPE key press
3e54f3a
change according to cr

meixg force-pushed the repl-escape-preview branch from 24cec13 to 3e54f3aCompare March 10, 2023 11:36

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2023

meixg added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2023

This was referenced Mar 12, 2023
CI Reliability 2023-03-12 nodejs/reliability#521
Open
CI Reliability 2023-03-13 nodejs/reliability#522
Open

github-actionsBot mentioned this pull request Mar 14, 2023
CI Reliability 2023-03-14 nodejs/reliability#523
Open
24 tasks

BridgeAR approved these changes Mar 14, 2023
View reviewed changes

This was referenced Mar 15, 2023
CI Reliability 2023-03-15 nodejs/reliability#524
Open
CI Reliability 2023-03-16 nodejs/reliability#525
Open

meixg added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 16, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 16, 2023

nodejs-github-bot merged commit 2566400 into nodejs:mainMar 16, 2023

This was referenced Mar 17, 2023
CI Reliability 2023-03-17 nodejs/reliability#526
Open
CI Reliability 2023-03-18 nodejs/reliability#527
Open

targos pushed a commit that referenced this pull request Mar 18, 2023
repl: preserve preview on ESCAPE key press
d6a1232
Fix: #46876 PR-URL: #46878Fixes: #46876 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

This was referenced Apr 3, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged
v19.9.0 proposal #47441
Merged

danielleadams pushed a commit that referenced this pull request Jul 6, 2023
repl: preserve preview on ESCAPE key press
e668efa
Fix: #46876 PR-URL: #46878Fixes: #46876 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

danielleadams mentioned this pull request Jul 10, 2023
v18.17.0 release proposal #48694
Merged

meixg deleted the repl-escape-preview branch April 21, 2026 06:44

Uh oh!

Uh oh!

Conversation

meixg commented Feb 28, 2023• edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 28, 2023

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 28, 2023

Uh oh!

meixg commented Feb 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Feb 28, 2023

Uh oh!

nodejs-github-bot commented Mar 1, 2023

Uh oh!

nodejs-github-bot commented Mar 3, 2023

Uh oh!

nodejs-github-bot commented Mar 3, 2023

Uh oh!

nodejs-github-bot commented Mar 5, 2023

Uh oh!

nodejs-github-bot commented Mar 6, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 11, 2023

Uh oh!

nodejs-github-bot commented Mar 13, 2023

Uh oh!

nodejs-github-bot commented Mar 14, 2023

Uh oh!

nodejs-github-bot commented Mar 14, 2023

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

meixg commented Feb 28, 2023•
edited by aduh95
Loading

meixg commented Feb 28, 2023•
edited
Loading