Skip to content

test: update WPT fixtures resources, common, streams, FileAPI - #46912

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:update-wpt-fixtures
Closed

test: update WPT fixtures resources, common, streams, FileAPI#46912
panva wants to merge 1 commit into
nodejs:mainfrom
panva:update-wpt-fixtures

Conversation

@panva

@panvapanva commented Mar 2, 2023

Copy link
Copy Markdown
Member

Pulled in updated testharness (resources), which prompted the update to resources, then streams, then FileAPI.

The non fixture changes are

  • set the right globals so that the updated testharness gets used to determine the right test titles in the ShellTestEnvironment we end up utilizing (thanks to web-platform-tests/wpt@46e1750)
  • tests that require gc now load a specific script, when that script is detected the worker automatically loads and assigns gc to globalThis
  • cleanup of fixture files that are no longer in the wpt repo that aren't cleaned up during git node wpt ... (issue opened git node wpt only updates or creates files, doesn't remove them node-core-utils#678)
  • re-fetching webmessaging/broadcastchannel that was missing in versions.json

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 2, 2023
@panva
panvaforce-pushed the update-wpt-fixtures branch from 01fedc4 to 315dd65CompareMarch 2, 2023 17:12
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2023
@nodejs-github-bot

This comment was marked as outdated.

@panva
panva marked this pull request as draft March 2, 2023 18:05
@panva
panva marked this pull request as ready for review March 2, 2023 18:51
@panva
panvaforce-pushed the update-wpt-fixtures branch from 315dd65 to c31504fCompareMarch 2, 2023 18:51
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@panva
panvaforce-pushed the update-wpt-fixtures branch from ed6dac4 to c65027fCompareMarch 3, 2023 08:39
@nodejs-github-bot

This comment was marked as outdated.

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Mar 3, 2023
@panva
panvaforce-pushed the update-wpt-fixtures branch from c65027f to d89ed50CompareMarch 6, 2023 14:44
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 6, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

nodejs-github-bot commented Mar 6, 2023

Copy link
Copy Markdown
Collaborator

@panva

panva commented Mar 7, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 68e8390

panva added a commit that referenced this pull request Mar 7, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panvapanva closed this Mar 7, 2023
@panva
panva deleted the update-wpt-fixtures branch March 7, 2023 10:34
targos pushed a commit that referenced this pull request Mar 13, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
PR-URL: #46912
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Mar 14, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@panva@nodejs-github-bot@anonrig@tniessen@danielleadams