Uh oh!
There was an error while loading. Please reload this page.
doc: use number which is bigger than 1024 as port in http2 - #46938
Merged
nodejs-github-bot merged 1 commit intoMar 6, 2023
Conversation
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2.
nodejs-github-bot
commented
Mar 3, 2023
Collaborator
Review requested:
|
cjihrig
approved these changes
Mar 3, 2023
ShogunPanda
approved these changes
Mar 3, 2023
tniessen
approved these changes
Mar 3, 2023
lpinca
approved these changes
Mar 3, 2023
RafaelGSS
approved these changes
Mar 4, 2023
nodejs-github-bot
commented
Mar 4, 2023
Collaborator
nodejs-github-bot
commented
Mar 5, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/46938 ✔ Done loading data for nodejs/node/pull/46938 ----------------------------------- PR info ------------------------------------ Title doc: use number which is bigger than 1024 as port in http2 (#46938) Author Deokjin Kim (@deokjinkim) Branch deokjinkim:230303_use_bigger_than_1024 -> nodejs:main Labels doc, http2, author ready Commits 1 - doc: use number which is bigger than 1024 as port in http2 Committers 1 - Deokjin Kim PR-URL: https://github.com/nodejs/node/pull/46938 Reviewed-By: Matteo Collina Reviewed-By: Colin Ihrig Reviewed-By: Paolo Insogna Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/46938 Reviewed-By: Matteo Collina Reviewed-By: Colin Ihrig Reviewed-By: Paolo Insogna Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 03 Mar 2023 14:12:41 GMT ✔ Approvals: 6 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/46938#pullrequestreview-1323895286 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/46938#pullrequestreview-1323901563 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/46938#pullrequestreview-1323962095 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/46938#pullrequestreview-1324203048 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/46938#pullrequestreview-1324273293 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/46938#pullrequestreview-1325020498 ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4336495071 |
nodejs-github-bot
commented
Mar 5, 2023
Collaborator
20 tasks
nodejs-github-bot
commented
Mar 6, 2023
Collaborator
Landed in c425a6f |
This was referenced Mar 7, 2023
targos pushed a commit
that referenced
this pull request
Mar 13, 2023
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2. PR-URL: #46938 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit
that referenced
this pull request
Mar 14, 2023
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2. PR-URL: #46938 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams pushed a commit
that referenced
this pull request
Apr 11, 2023
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2. PR-URL: #46938 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 80 port, user should run example with root permission. To avoid such situation, use 8000 or 8443 as port number in example of http2.