Skip to content

inspector: log response and requests in the inspector for debugging - #46941

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:inspector-debug
Mar 22, 2023
Merged

inspector: log response and requests in the inspector for debugging#46941
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
joyeecheung:inspector-debug

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Mar 3, 2023

Copy link
Copy Markdown
Member

Logs the raw messages from the inspector when NODE_DEBUG_NATIVE is set to inspector_server to facilitate debugging.

@joyeecheung
inspector: log response and requests in the inspector for debugging
54eb7bb
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Mar 3, 2023
@joyeecheung

joyeecheung commented Mar 3, 2023

Copy link
Copy Markdown
MemberAuthor

By the way I am not sure since when we stopped using INSPECTOR_SERVER, but before this patch INSPECTOR_SERVER is otherwise unused.

@nodejs-github-bot

nodejs-github-bot commented Mar 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50192/

addaleax
addaleax reviewed Mar 3, 2023
View reviewed changes
Comment threadsrc/inspector_agent.cc Outdated
Comment threadsrc/inspector_agent.cc Outdated
@joyeecheung@addaleax
fixup! inspector: log response and requests in the inspector for debu…
5179c81
…gging
Co-authored-by: Anna Henningsen <github@addaleax.net>
This was referenced Mar 8, 2023
Open
Open
Open
Open
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50357/

@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 17, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/46941
✔ Done loading data for nodejs/node/pull/46941
----------------------------------- PR info ------------------------------------
Title inspector: log response and requests in the inspector for debugging (#46941)
Author Joyee Cheung (@joyeecheung)
Branch joyeecheung:inspector-debug -> nodejs:main
Labels c++, inspector, needs-ci, commit-queue-squash
Commits 2
- inspector: log response and requests in the inspector for debugging
- fixup! inspector: log response and requests in the inspector for debu…
Committers 2
- Joyee Cheung - GitHub PR-URL: https://github.com/nodejs/node/pull/46941
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/46941
--------------------------------------------------------------------------------
⚠ Commits were pushed since the last review:
⚠ - fixup! inspector: log response and requests in the inspector for debu…
ℹ This PR was created on Fri, 03 Mar 2023 18:15:18 GMT
✘ Approvals: 0
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2023-03-13T16:29:57Z: https://ci.nodejs.org/job/node-test-pull-request/50357/
- Querying data for job/node-test-pull-request/50357/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/4451496611

@joyeecheung

joyeecheung commented Mar 18, 2023

Copy link
Copy Markdown
MemberAuthor

cc @nodejs/inspector @nodejs/cpp-reviewers can I have some review please?

RafaelGSS
RafaelGSS approved these changes Mar 18, 2023
View reviewed changes

@RafaelGSSRafaelGSS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50447/

This was referenced Mar 19, 2023
Open
Open
@nodejs-github-bot

nodejs-github-bot commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50490/

@nodejs-github-bot

nodejs-github-bot commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50502/

@github-actionsgithub-actionsBot mentioned this pull request Mar 21, 2023
Open
19 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50526/

@debadree25debadree25 mentioned this pull request Mar 21, 2023
Closed
@github-actionsgithub-actionsBot mentioned this pull request Mar 22, 2023
Open
19 tasks
@joyeecheungjoyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 434bdde into nodejs:mainMar 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in 434bdde

@github-actionsgithub-actionsBot mentioned this pull request Mar 23, 2023
Open
33 tasks
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@joyeecheung@RafaelGSS
inspector: log response and requests in the inspector for debugging
ac44246
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.
PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@joyeecheung@RafaelGSS
inspector: log response and requests in the inspector for debugging
e33dfce
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.
PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@joyeecheung@danielleadams
inspector: log response and requests in the inspector for debugging
70c0e88
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.
PR-URL: #46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax left review comments
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.inspectorIssues and PRs related to the V8 inspector protocolneeds-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joyeecheung@nodejs-github-bot@addaleax@RafaelGSS@RaisinTen