Uh oh!
There was an error while loading. Please reload this page.
benchmark: update README to include all benchmarks - #46991
Conversation
aduh95
commented
Mar 7, 2023
Since it looks like we are not doing a good job at maintaining that table, what if we removed it? I don't think it's very useful, and without tests it seems inevitable that it will one day or another get back to an outdated state. |
cola119
commented
Mar 7, 2023
As a beginner in benchmarking, I find the table not very helpful, and I believe that documents describing the |
anonrig
commented
Mar 7, 2023
I agree with @aduh95 here. This is the first time I saw this document :-) |
Theo-Steiner
commented
Mar 8, 2023
I've reverted the previous changes and included a description of the directory structure in place of the outdated table. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
anonrig
commented
Mar 8, 2023
Can you update the initial commit title & pull-request title to a more relevant one @Theo-Steiner? |
anonrig
left a comment
There was a problem hiding this comment.
LGTM when first commit title is changed to a more relevant title for the current changes.
29f2380 to
101dc0aCompareThe markdown table in `benchmark/README.md` has grown stale, no longer providing an overview over all existing benchmarks. As it has proven difficult to keep an exhaustive listing of available benchmarks up to date, this commit provides a description of how the directory is structured instead.
101dc0a to
182abbeComparenodejs-github-bot
commented
Mar 11, 2023
Landed in 10c1ab0 |
The markdown table in `benchmark/README.md` has grown stale, no longer providing an overview over all existing benchmarks. As it has proven difficult to keep an exhaustive listing of available benchmarks up to date, this commit provides a description of how the directory is structured instead. PR-URL: #46991 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The markdown table in `benchmark/README.md` has grown stale, no longer providing an overview over all existing benchmarks. As it has proven difficult to keep an exhaustive listing of available benchmarks up to date, this commit provides a description of how the directory is structured instead. PR-URL: #46991 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
The markdown table in `benchmark/README.md` has grown stale, no longer providing an overview over all existing benchmarks. As it has proven difficult to keep an exhaustive listing of available benchmarks up to date, this commit provides a description of how the directory is structured instead. PR-URL: #46991 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Background
During #46731@cola119 mentioned that the benchmark for readline was not documented in
benchmark/README.md.This PR will fix this (and also add other unmentioned benchmarks).
Update the markdown table in
benchmark/README.mdThe content of
benchmark/README.mdhas become stale, no longer providing an overview over all existing benchmarks. To address this, the markdown table has been updated to incorporate all current benchmarks.Move benchmarks for parts of submodules into the corresponding directory
Furthermore, some benchmarks were in separate directories from the benchmarks of their respective node submodules. These benchmarks have been moved into the directory of their submodule.