Skip to content

tools: automate cares update - #46993

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-cares-update
Mar 10, 2023
Merged

tools: automate cares update#46993
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
marco-ippolito:feat/automate-cares-update

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Mar 7, 2023

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Mar 7, 2023
@aduh95

aduh95 commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

@marco-ippolito

marco-ippolito commented Mar 7, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Would you be interested in doing something similar to what was done in #46488 by @tony-go? If not, no problem, it can be done in a follow-up PR.

yes! I moved cares to the new folder, will update it like in the pr you linked.
I'll open a new pr to update all other scripts.

tony-go
tony-go approved these changes Mar 7, 2023
View reviewed changes

@tony-gotony-go left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

richardlau
richardlau reviewed Mar 7, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-cares.sh Outdated
@marco-ippolito@richardlau
fix: typo
8ed3876
Co-authored-by: Richard Lau <rlau@redhat.com>
anonrig
anonrig reviewed Mar 7, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-cares.sh Outdated
Comment threadtools/dep_updaters/update-cares.sh
Comment threadtools/dep_updaters/update-cares.sh
RafaelGSS
RafaelGSS reviewed Mar 7, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-cares.sh
aduh95
aduh95 reviewed Mar 7, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-c-ares.md Outdated
aduh95
aduh95 reviewed Mar 7, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-c-ares.sh Outdated
@marco-ippolito@aduh95
fix: curl
3c68f46
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50279/

@nodejs-github-bot

nodejs-github-bot commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50286/

@marco-ippolitomarco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2023
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3591728 into nodejs:mainMar 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3591728

targos pushed a commit that referenced this pull request Mar 13, 2023
@marco-ippolito@targos
tools: automate cares update
49a5c03
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@marco-ippolito@targos
tools: automate cares update
2e7ba31
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@marco-ippolito@danielleadams
tools: automate cares update
a3f272e
PR-URL: #46993
Refs: nodejs/security-wg#828
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlaurichardlaurichardlau left review comments
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@aduh95aduh95aduh95 approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@tony-gotony-gotony-go approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marco-ippolito@aduh95@nodejs-github-bot@benjamingr@anonrig@richardlau@tony-go@RafaelGSS