Uh oh!
There was an error while loading. Please reload this page.
src: remove unused v8::Uint32Array from encoding - #47003
Merged
Merged
Conversation
Contributor
Fast-track has been requested by @anonrig. Please 👍 to approve. |
joyeecheung
approved these changes
Mar 7, 2023
joyeecheung
left a comment
Member
There was a problem hiding this comment.
Thanks for catching it!
(hmm, weird, somehow the fixup was only partially applied by git? 🤯 )
cjihrig
approved these changes
Mar 7, 2023
Qard
approved these changes
Mar 7, 2023
nodejs-github-bot
commented
Mar 7, 2023
Collaborator
Trott
approved these changes
Mar 7, 2023
richardlau
approved these changes
Mar 8, 2023
nodejs-github-bot
commented
Mar 8, 2023
Collaborator
Landed in f94ef7c |
targos pushed a commit
that referenced
this pull request
Mar 13, 2023
PR-URL: #47003 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
targos pushed a commit
that referenced
this pull request
Mar 14, 2023
PR-URL: #47003 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced by commit e5933c8, this pull request removes the unused include which causes cpp linting error.
cc @joyeecheung