Skip to content

test: move test-tls-autoselectfamily-servername to test/internet - #47029

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:test-internet-dns
Mar 11, 2023
Merged

test: move test-tls-autoselectfamily-servername to test/internet#47029
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:test-internet-dns

Conversation

@aduh95

@aduh95aduh95 commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

And switch from google.com to nodejs.org.

@aduh95
test: move test-tls-autoselectfamily-servername to test/internet
7331c24
And switch from `google.com` to `nodejs.org`.
@aduh95
aduh95 requested a review from ShogunPandaMarch 9, 2023 13:48
@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 9, 2023
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@github-actions

github-actionsBot commented Mar 9, 2023

Copy link
Copy Markdown
Contributor
Failed to start CI
- Validating Jenkins credentials
✔ Jenkins credentials valid
- Starting PR CI job
✘ Failed to start PR CI: 403 Forbidden
https://github.com/nodejs/node/actions/runs/4375426438

richardlau
richardlau reviewed Mar 9, 2023
View reviewed changes
Comment threadtest/internet/test-tls-autoselectfamily-servername.js Outdated
@aduh95aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 9, 2023
@aduh95aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 9, 2023
ShogunPanda
ShogunPanda approved these changes Mar 10, 2023
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aduh95

aduh95 commented Mar 10, 2023

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/50298/ 💛

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 11, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 03fd5ae into nodejs:mainMar 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 03fd5ae

targos pushed a commit that referenced this pull request Mar 13, 2023
@aduh95@targos
test: move test-tls-autoselectfamily-servername to test/internet
5be908d
And switch from `google.com` to `nodejs.org`.
PR-URL: #47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Mar 14, 2023
@aduh95@targos
test: move test-tls-autoselectfamily-servername to test/internet
11509a4
And switch from `google.com` to `nodejs.org`.
PR-URL: #47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@aduh95@danielleadams
test: move test-tls-autoselectfamily-servername to test/internet
ba340a0
And switch from `google.com` to `nodejs.org`.
PR-URL: #47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
@mhdawsonmhdawson mentioned this pull request Jul 27, 2023
Merged
mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 4, 2023
@aduh95@mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
26d38d0
And switch from `google.com` to `nodejs.org`.
PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@mhdawsonmhdawson mentioned this pull request Aug 4, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Aug 14, 2023
@aduh95@ruyadorno
test: move test-tls-autoselectfamily-servername to test/internet
a9441de
And switch from `google.com` to `nodejs.org`.
PR-URL: #47029
Backport-PR-URL: #49016
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadornoruyadorno added backported-to-v18.x and removed needs-ci PRs that need a full CI run. backported-to-v18.x labels Aug 14, 2023
@mhdawsonmhdawson mentioned this pull request Aug 15, 2023
Closed
@mhdawson

mhdawson commented Aug 15, 2023

Copy link
Copy Markdown
Member

Backport to 18.x PR (second try) - #49183

mhdawson pushed a commit to mhdawson/io.js that referenced this pull request Aug 15, 2023
@aduh95@mhdawson
test: move test-tls-autoselectfamily-servername to test/internet
bc475f5
And switch from `google.com` to `nodejs.org`.
PR-URL: nodejs#47029
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
ruyadorno pushed a commit that referenced this pull request Aug 17, 2023
@aduh95@ruyadorno
test: move test-tls-autoselectfamily-servername to test/internet
6de7aa1
And switch from `google.com` to `nodejs.org`.
PR-URL: #47029
Backport-PR-URL: #49183
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadornoruyadorno mentioned this pull request Aug 17, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@richardlaurichardlaurichardlau approved these changes
@MoLowMoLowMoLow approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@aduh95@nodejs-github-bot@mhdawson@ShogunPanda@lpinca@cjihrig@tniessen@richardlau@MoLow@ruyadorno