Skip to content

Fix typo in test.md - #47053

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vhiairrassary:patch-1
Mar 13, 2023
Merged

Fix typo in test.md#47053
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
vhiairrassary:patch-1

Conversation

@vhiairrassary

@vhiairrassaryvhiairrassary commented Mar 12, 2023

Copy link
Copy Markdown
Contributor

Fix typo in test.md (invalid case).

@nodejs-github-bot

nodejs-github-bot commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v14.x test_runner Issues and PRs related to the test runner subsystem. labels Mar 12, 2023
@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 12, 2023
@benjamingrbenjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 13, 2023
@github-actions

github-actionsBot commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1ef4faa into nodejs:mainMar 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1ef4faa

@vhiairrassary
vhiairrassary deleted the patch-1 branch March 13, 2023 12:16
targos pushed a commit that referenced this pull request Mar 13, 2023
@vhiairrassary@targos
doc: fix typo in test.md
1e8fe6f
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Mar 14, 2023
@vhiairrassary@targos
doc: fix typo in test.md
89f31a1
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request Mar 14, 2023
Merged
danielleadams pushed a commit that referenced this pull request Apr 11, 2023
@vhiairrassary@danielleadams
doc: fix typo in test.md
01d8267
PR-URL: #47053
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Apr 11, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@cjihrigcjihrigcjihrig approved these changes
@Ayase-252Ayase-252Ayase-252 approved these changes
@MoLowMoLowMoLow approved these changes
+1 more reviewer
@juliangruberjuliangruberjuliangruber approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vhiairrassary@nodejs-github-bot@juliangruber@Trott@benjamingr@cjihrig@Ayase-252@MoLow