Skip to content

test,crypto: update WebCryptoAPI WPT - #47131

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-update-crypto
Mar 19, 2023
Merged

test,crypto: update WebCryptoAPI WPT#47131
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-update-crypto

Conversation

@panva

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI

@panvapanva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. webcrypto labels Mar 17, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@tniessen

Copy link
Copy Markdown
Member

@panva looks like all CI failures are due to #47116, which should not be as much of an issue now that #47134 was merged. I'm not sure if resuming CI actually rebases on top of main every time -- so feel free to either resume or start a new CI :)

@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@panva
panvaforce-pushed the wpt-update-crypto branch from 4d3cf0b to d64df82CompareMarch 17, 2023 16:47

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 17, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 142d6af into nodejs:mainMar 19, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 142d6af

@panva
panva deleted the wpt-update-crypto branch March 20, 2023 10:53
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47131
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@panva@nodejs-github-bot@tniessen@lpinca