Uh oh!
There was an error while loading. Please reload this page.
src: replace impossible THROW with CHECK - #47168
Merged
nodejs-github-bot merged 1 commit intoMar 22, 2023
Merged
Conversation
nodejs-github-bot
commented
Mar 20, 2023
Collaborator
Review requested:
|
tniessenforce-pushed
the
dsa-params-divisor-bits-check
branch
from
March 20, 2023 02:33
7cc374b to
c71e779CompareThe JS layer already verifies that divisor_bits is either a non-negative 32-bit signed integer or null/undefined, in which case it passes -1 to the C++ layer. In either case, the C++ layer receives a 32-bit signed integer greater than or equal to -1.
tniessenforce-pushed
the
dsa-params-divisor-bits-check
branch
from
March 20, 2023 02:57
c71e779 to
19df782CompareRaisinTen
approved these changes
Mar 20, 2023
nodejs-github-bot
commented
Mar 20, 2023
Collaborator
lpinca
approved these changes
Mar 20, 2023
19 tasks
nodejs-github-bot
commented
Mar 21, 2023
Collaborator
19 tasks
nodejs-github-bot
commented
Mar 22, 2023
Collaborator
nodejs-github-bot
commented
Mar 22, 2023
Collaborator
Landed in 1a18b44 |
33 tasks
RafaelGSS pushed a commit
that referenced
this pull request
Apr 5, 2023
The JS layer already verifies that divisor_bits is either a non-negative 32-bit signed integer or null/undefined, in which case it passes -1 to the C++ layer. In either case, the C++ layer receives a 32-bit signed integer greater than or equal to -1. PR-URL: #47168 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Apr 7, 2023
The JS layer already verifies that divisor_bits is either a non-negative 32-bit signed integer or null/undefined, in which case it passes -1 to the C++ layer. In either case, the C++ layer receives a 32-bit signed integer greater than or equal to -1. PR-URL: #47168 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
The JS layer already verifies that divisor_bits is either a non-negative 32-bit signed integer or null/undefined, in which case it passes -1 to the C++ layer. In either case, the C++ layer receives a 32-bit signed integer greater than or equal to -1. PR-URL: #47168 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS layer already verifies that
divisor_bitsis either a non-negative 32-bit signed integer ornull/undefined, in which case it passes-1to the C++ layer. In either case, the C++ layer receives a 32-bit signed integer greater than or equal to-1.