Skip to content

url: add pending-deprecation to url.parse() - #47203

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:pending-deprecation-url-parse
Mar 23, 2023
Merged

url: add pending-deprecation to url.parse()#47203
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
anonrig:pending-deprecation-url-parse

Conversation

@anonrig

@anonriganonrig commented Mar 21, 2023

Copy link
Copy Markdown
Member

I propose adding support for --pending-deprecation for the url.parse() method. The new improvements in WHATWG URL and Ada hints us towards a runtime deprecation in the upcoming years.

@nodejs-github-bot

nodejs-github-bot commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels Mar 21, 2023
@anonrig
anonrigforce-pushed the pending-deprecation-url-parse branch from 30891b9 to 6ef70ebCompareMarch 21, 2023 19:40
@anonrig

anonrig commented Mar 21, 2023

Copy link
Copy Markdown
MemberAuthor

@nodejs/tsc please review

@anonrig
anonrigforce-pushed the pending-deprecation-url-parse branch from 6ef70eb to e921846CompareMarch 21, 2023 19:47
@anonriganonrig added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Mar 21, 2023
joyeecheung
joyeecheung reviewed Mar 21, 2023
View reviewed changes
Comment threadlib/url.js Outdated
@anonrig
anonrigforce-pushed the pending-deprecation-url-parse branch from e921846 to 476c1eeCompareMarch 21, 2023 22:10
mscdex
mscdex reviewed Mar 21, 2023
View reviewed changes
Comment threadlib/url.js Outdated
jasnell
jasnell approved these changes Mar 21, 2023
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @mscdex's suggestion applied.

mcollina
mcollina approved these changes Mar 22, 2023
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50548/

@github-actionsgithub-actionsBot mentioned this pull request Mar 23, 2023
Open
33 tasks
@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50567/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 27335cd into nodejs:mainMar 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 27335cd

@anonrig
anonrig deleted the pending-deprecation-url-parse branch March 23, 2023 19:52
@tniessen

tniessen commented Mar 23, 2023

Copy link
Copy Markdown
Member

Why is this semver-major? IIRC we don't treat "pending deprecation" as breaking (or notable). The deprecation is still documentation-only. The original introduction of the documentation-only status was a notable change, yet not semver-major.

@anonriganonrig removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 23, 2023
@anonrig

anonrig commented Mar 23, 2023

Copy link
Copy Markdown
MemberAuthor

Thank you @tniessen. I wasn't aware of that. I removed the label.

@tniessen

tniessen commented Mar 23, 2023

Copy link
Copy Markdown
Member

That way we can backport it :)

@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@anonrig@RafaelGSS
url: add pending-deprecation to url.parse()
429b6f6
PR-URL: #47203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@anonrig@RafaelGSS
url: add pending-deprecation to url.parse()
461ef04
PR-URL: #47203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig@danielleadams
url: add pending-deprecation to url.parse()
7fb1980
PR-URL: #47203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@legendecaslegendecaslegendecas approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+1 more reviewer
@mscdexmscdexmscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.deprecationsIssues and PRs related to deprecations.needs-ciPRs that need a full CI run.urlIssues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@anonrig@nodejs-github-bot@tniessen@mcollina@mscdex@jasnell@joyeecheung@BethGriggs@legendecas@RaisinTen