Skip to content

deps: V8: cherry-pick 975ff4dbfd1b - #47209

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debadree25:fix/proxy-own-keys-trap-fix
Mar 24, 2023
Merged

deps: V8: cherry-pick 975ff4dbfd1b#47209
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
debadree25:fix/proxy-own-keys-trap-fix

Conversation

@debadree25

@debadree25debadree25 commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Original commit message:

fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}

Refs: v8/v8@975ff4d
Fixes: #41714

@debadree25
deps: V8: cherry-pick 975ff4dbfd1b
17c2a3b
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@debadree25
debadree25 requested a review from targosMarch 22, 2023 07:10
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Mar 22, 2023
@debadree25debadree25 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50538/

@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5233/

@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5233/

@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2023
@debadree25debadree25 mentioned this pull request Mar 22, 2023
Merged
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 22, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e203f1 into nodejs:mainMar 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e203f1

@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@debadree25@RafaelGSS
deps: V8: cherry-pick 975ff4dbfd1b
239e25a
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@debadree25@RafaelGSS
deps: V8: cherry-pick 975ff4dbfd1b
ed3df3a
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@debadree25@RafaelGSS
deps: V8: cherry-pick 975ff4dbfd1b
8a69929
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@debadree25@danielleadams
deps: V8: cherry-pick 975ff4dbfd1b
29ba98a
Original commit message:
fix GetPropertyNames for proxys with ownKeys trap
Added checks to FilterProxyKeys function for when skip_indices is
enabled.
Bug: v8:13728
Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#86548}
Refs: v8/v8@975ff4d
PR-URL: #47209Fixes: #41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
@ErickWendelErickWendelErickWendel approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

assert.deepEqual and assert.deepStrictEqual incorrectly compare Proxied arrays when using ownKeys trap

6 participants

@debadree25@nodejs-github-bot@targos@gengjiawen@richardlau@ErickWendel