Skip to content

meta: update link to collaborators discussion page - #47211

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:nomination
Mar 25, 2023
Merged

meta: update link to collaborators discussion page#47211
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:nomination

Conversation

@targos

@targostargos commented Mar 22, 2023

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Mar 22, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 22, 2023
VoltrexKeyva
VoltrexKeyva reviewed Mar 22, 2023
View reviewed changes
Comment threadGOVERNANCE.md Outdated
targos
targos commented Mar 22, 2023
View reviewed changes
Comment threadGOVERNANCE.md Outdated
mhdawson
mhdawson approved these changes Mar 22, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47211
✔ Done loading data for nodejs/node/pull/47211
----------------------------------- PR info ------------------------------------
Title meta: update link to collaborators discussion page (#47211)
Author Michaël Zasso (@targos)
Branch targos:nomination -> nodejs:main
Labels meta
Commits 2
- meta: update link to collaborators discussion page
- Update GOVERNANCE.md
Committers 2
- Michaël Zasso - GitHub PR-URL: https://github.com/nodejs/node/pull/47211
Refs: https://github.com/nodejs/TSC/issues/1340
Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Darshan Sen Reviewed-By: Rafael Gonzaga Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/47211
Refs: https://github.com/nodejs/TSC/issues/1340
Reviewed-By: Richard Lau Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: Darshan Sen Reviewed-By: Rafael Gonzaga Reviewed-By: Rich Trott --------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 Mar 2023 10:36:39 GMT
✔ Approvals: 6
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1352768966
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353437393
✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353455553
✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1353969775
✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1354315516
✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/47211#pullrequestreview-1355941254
✔ Last GitHub CI successful
ℹ Green GitHub CI is sufficient
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 47211
From https://github.com/nodejs/node
* branch refs/pull/47211/merge -> FETCH_HEAD
✔ Fetched commits as 94ec71d38583..599dab364ba8
--------------------------------------------------------------------------------
[main 28f186f559] meta: update link to collaborators discussion page
Author: Michaël Zasso Date: Wed Mar 22 11:35:51 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
[main 5e41fedb4a] Update GOVERNANCE.md
Author: Michaël Zasso Date: Wed Mar 22 13:32:03 2023 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
✔ Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

⚠ Found Refs: nodejs/TSC#1340, skipping..

--------------------------------- New Message ----------------------------------

meta: update link to collaborators discussion page
Refs: nodejs/TSC#1340

PR-URL: #47211

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Michael Dawson midawson@redhat.com

Reviewed-By: Darshan Sen raisinten@gmail.com

Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

Reviewed-By: Rich Trott rtrott@gmail.com
[detached HEAD 821a778356] meta: update link to collaborators discussion page

Author: Michaël Zasso targos@protonmail.com

Date: Wed Mar 22 11:35:51 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update GOVERNANCE.md
PR-URL: #47211

Refs: nodejs/TSC#1340

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Michael Dawson midawson@redhat.com

Reviewed-By: Darshan Sen raisinten@gmail.com

Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com

Reviewed-By: Rich Trott rtrott@gmail.com
[detached HEAD 2063ea4798] Update GOVERNANCE.md

Author: Michaël Zasso targos@protonmail.com

Date: Wed Mar 22 13:32:03 2023 +0100

1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/4519020911

@nodejs-github-botnodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 25, 2023
@targostargos added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 06c91af into nodejs:mainMar 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 06c91af

@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@targos@RafaelGSS
meta: update link to collaborators discussion page
138db9f
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@targos@RafaelGSS
meta: update link to collaborators discussion page
44a767e
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@targos@RafaelGSS
meta: update link to collaborators discussion page
22b9acd
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos
targos deleted the nomination branch April 28, 2023 15:24
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos@danielleadams
meta: update link to collaborators discussion page
1f08f48
Refs: nodejs/TSC#1340
PR-URL: #47211
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@RaisinTenRaisinTenRaisinTen approved these changes
+2 more reviewers
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@targos@nodejs-github-bot@Trott@lpinca@richardlau@mhdawson@RafaelGSS@RaisinTen@VoltrexKeyva