create vee-eight-4.9 branch - #4722

Merged

targos merged 9 commits into

nodejs:vee-eight-4.9from

targos:vee-eight-4.9

Feb 8, 2016

targos commented Jan 16, 2016

Member

The V8 team just cut the 4.9 branch so I started working on its integration.

That's still a work in progress but I'm creating the PR now because I have issues with a failing test and we will have to discuss about what we do with the V8 APIs that have been deprecated in 4.9 (as an example, I fixed the deprecation warning about String::NewFromOneByte here).
The branch cannot be built without manually copying the trace_event dependency (see nodejs/build#304)

cc @ofrobots @nodejs/v8

targos added the v8 engine label

targos force-pushed the vee-eight-4.9 branch from 3ed3d94 to 8f5aba4Compare

January 19, 2016 14:55

ofrobots commented Jan 19, 2016

Contributor

@targos Can you cherry pick e9f499e and b83a33f as the solution for nodejs/build#304?

ofrobots commented Jan 19, 2016

Contributor

Oh, I see that you already added that commit to your list. You can ignore the previous message.

targos force-pushed the vee-eight-4.9 branch from 8f5aba4 to 9f18896Compare

January 22, 2016 08:25

ofrobots commented Jan 24, 2016

Contributor

@targos I updated to 4.9.385.11, and added some commits here: https://github.com/ofrobots/node/commits/vee-eight-4.9. With this the tests are now fully passing. There are still some deprecation warnings that need to be ironed out, but this is looking good to land into the vee-eight-4.9 branch.

Your commits LGTM.

targos force-pushed the vee-eight-4.9 branch from 9f18896 to 0af2053Compare

January 24, 2016 20:05

targos commented Jan 24, 2016

MemberAuthor

@ofrobots thanks, I picked up your branch here

targos force-pushed the vee-eight-4.9 branch from 0af2053 to 4e8580bCompare

January 25, 2016 20:45

targos commented Jan 25, 2016

MemberAuthor

thanks @ofrobots. I updated the proxy tab-completion test.
Tests are passing locally. Let's try a CI: https://ci.nodejs.org/job/node-test-commit/1913/

ChALkeR commented Jan 25, 2016

Member

ChALkeR mentioned this pull request

src: v8 deprecations in 4.9 branch #4869

Closed

4 tasks

rvagg commented Jan 26, 2016

Member

/cc @nodejs/addon-api, also see #4869, I haven't looked at this but it sounds like there's enough movement that it impacts NAN. Node.js v6 will be out with at least V8 v4.9, hopefully V8 v5.0.

ofrobots commented Jan 26, 2016

Contributor

Part of the problem here has been that we are only now getting to integrating V8 4.9 with Node.js. V8 4.9 is not stable yet, so if there is a deal breaker deprecation, let's provide the feedback to the V8 team and see what can be one.

targos commented Jan 26, 2016

MemberAuthor

I pushed two new V8 deprecation-related commits.

Perhaps we could go with a review of the PR as it is now, merge it into vee-eight-4.9 and continue the integration from there ?

ofrobots commented Jan 26, 2016

Contributor

@targos Your commits LGTM. Someone else will have to review mine.

targos commented Jan 29, 2016

MemberAuthor

ping @nodejs/v8 for additional review

ofrobots commented Feb 1, 2016

Contributor

@targos perhaps you can review my commits.

bnoordhuis commented Feb 4, 2016

Member

Style nits but otherwise LGTM.

targos force-pushed the vee-eight-4.9 branch from 477e620 to 8e49a50Compare

February 5, 2016 09:43

targos commented Feb 6, 2016

MemberAuthor

CI: https://ci.nodejs.org/job/node-test-commit/2134/

ofrobotsand others added 9 commits

February 8, 2016 12:46

deps: upgrade to V8 4.9.385.18

fdadc02

Pick up the current branch head for V8 4.9
v8/v8@1ecba0f
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

deps: edit v8 gitignore to allow trace_event copy

c0e11d8

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

deps: add V8 DEP trace_event

4b65870

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

test: fix tests after V8 upgrade

c51d488

- An error message changed for undefined references
- `let` is now allowed in sloppy mode
- ES2015 proxies are shipped and the `Proxy` global is now a function
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

test: fix proxy tab-completion test

9796b0c

Proxies support is now complete in V8. The tests needed slight modification to
match the spec implementation.
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

lib: wrap tick_processor scripts in IIFE

4c1433d

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

src: fix String::NewFromOneByte deprecation warnings

01de50d

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

src: fix TryCatch deprecation warnings

4a341b0

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

src: fix NewInstance deprecation warnings

e4ad3ab

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

test: fix proxy tab-completion test

9169db0

Proxies support is now complete in V8. The tests needed slight modification to
match the spec implementation.
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

lib: wrap tick_processor scripts in IIFE

2ad71e6

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: fix String::NewFromOneByte deprecation warnings

2df2262

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: fix TryCatch deprecation warnings

600f475

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: fix NewInstance deprecation warnings

b55bd22

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

deps: upgrade to V8 4.9.385.18

f5ba0dc

Pick up the current branch head for V8 4.9
v8/v8@1ecba0f
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

deps: edit v8 gitignore to allow trace_event copy

32f4258

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

deps: add V8 DEP trace_event

1fd48c4

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

test: fix tests after V8 upgrade

e31a8f9

- An error message changed for undefined references
- `let` is now allowed in sloppy mode
- ES2015 proxies are shipped and the `Proxy` global is now a function
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

test: fix proxy tab-completion test

0faed0b

Proxies support is now complete in V8. The tests needed slight modification to
match the spec implementation.
PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit to ofrobots/node that referenced this pull request

lib: wrap tick_processor scripts in IIFE

513a895

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: replace deprecated String::NewFromOneByte

3b131cf

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: fix TryCatch deprecation warnings

330f757

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit to ofrobots/node that referenced this pull request

src: fix NewInstance deprecation warnings

360f04d

PR-URL: nodejs#4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots added a commit that referenced this pull request

deps: upgrade to V8 4.9.385.18

069e02a

Pick up the current branch head for V8 4.9
v8/v8@1ecba0f
PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit that referenced this pull request

deps: edit v8 gitignore to allow trace_event copy

89f2343

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit that referenced this pull request

deps: add V8 DEP trace_event

079973b

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots pushed a commit that referenced this pull request

test: fix tests after V8 upgrade

9968941

- An error message changed for undefined references
- `let` is now allowed in sloppy mode
- ES2015 proxies are shipped and the `Proxy` global is now a function
PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots added a commit that referenced this pull request

test: fix proxy tab-completion test

01f82f0

Proxies support is now complete in V8. The tests needed slight modification to
match the spec implementation.
PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots added a commit that referenced this pull request

lib: wrap tick_processor scripts in IIFE

953173b

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

ofrobots pushed a commit that referenced this pull request

src: replace deprecated String::NewFromOneByte

81f1732

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit that referenced this pull request

src: fix TryCatch deprecation warnings

79d7475

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

ofrobots pushed a commit that referenced this pull request

src: fix NewInstance deprecation warnings

ad0ce57

PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>

Fishrock123 mentioned this pull request

v5.8.0 proposal #5559

Merged

addaleax mentioned this pull request

Filled array displayed like [] in debug repl #6444

Closed

demurgos mentioned this pull request

Update nodejs compat for javascript.function.rest_parameters mdn/browser-compat-data#1744

Merged

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment