Skip to content

test,crypto: update WebCryptoAPI WPT - #47222

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-update-crypto
Mar 25, 2023
Merged

test,crypto: update WebCryptoAPI WPT#47222
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:wpt-update-crypto

Conversation

@panva

Copy link
Copy Markdown
Member

Just git node wpt WebCryptoAPI (again).

@panvapanva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Mar 22, 2023
@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 22, 2023
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonriganonrig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 23, 2023
@panvapanva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 24, 2023
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 24, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/47222
TypeError: fetch failed
at fetch (/opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/node_modules/undici/index.js:109:13)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async getCollaborators (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/collaborators.js:54:18)
at async PRData.getCollaborators (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:74:26)
at async Promise.all (index 0)
at async PRData.getAll (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/lib/pr_data.js:58:5)
at async getMetadata (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/components/metadata.js:18:3)
at async main (file:///opt/hostedtoolcache/node/18.15.0/x64/lib/node_modules/node-core-utils/components/git/land.js:200:22) {
cause: Error: certificate has expired
at TLSSocket.onConnectSecure (node:_tls_wrap:1540:34)
at TLSSocket.emit (node:events:513:28)
at TLSSocket._finishInit (node:_tls_wrap:959:8)
at ssl.onhandshakedone (node:_tls_wrap:743:12) {
code: 'CERT_HAS_EXPIRED'
}
}
https://github.com/nodejs/node/actions/runs/4515294803

@debadree25debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 25, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit a0ca15e into nodejs:mainMar 25, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in a0ca15e

@panva
panva deleted the wpt-update-crypto branch March 25, 2023 13:38
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
PR-URL: #47222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@lpinca@anonrig@tniessen@debadree25