Uh oh!
There was an error while loading. Please reload this page.
Upgrading Windows on ARM64 to a tier 2 platform - #47233
Conversation
p-b-o
commented
Mar 23, 2023
+1, this would be great to see windows-arm64 supported in NodeJS! |
mcollina
left a comment
There was a problem hiding this comment.
I'm +1. All things considered I would recommend we target v20.0.0.
mcollina
commented
Mar 23, 2023
tagging @nodejs/releasers for visibility |
niyas-sait
commented
Mar 23, 2023
Great! Looking forward to the release |
sxa
commented
Mar 23, 2023
@StefanStojanovic Can you summarise what is now in place to support this in terms of infrastructure? I haven't seen any of the details other than hearing that you've added some extra machines (From Azure?) into the CI. |
StefanStojanovic
commented
Mar 24, 2023
Certainly, here is the list of things we've done so far regarding the infrastructure:
ARM64 binaries are still cross-compiled from Windows x64, the same as before, so there are no additional machines for building neither in test nor in release CI. |
joaocgreis
commented
Mar 24, 2023
@mcollina we would certainly like to have this ready before Node v20! Do you mean that as well or do you see any reason why this shouldn't happen in v19? |
mcollina
commented
Mar 24, 2023
No specific reason! Go ahead for v19. |
mhdawson
commented
Mar 27, 2023
@nodejs/releasers FYI |
StefanStojanovic
commented
Mar 29, 2023
Is there something else I can do to help this move forward? |
StefanStojanovic
commented
Mar 30, 2023
@mcollina@richardlau@lpinca since I can neither start the CI (not sure it's needed for this change) nor land a PR, could someone of you move this forward? |
richardlau
commented
Mar 30, 2023
It isn't as it is a doc only change. |
nodejs-github-bot
commented
Mar 30, 2023
Landed in dad0b07 |
StefanStojanovic
commented
Mar 30, 2023
Thank you everyone for helping push this across the finish line! |
p-b-o
commented
Mar 30, 2023
Awesome! |
Refs: nodejs/build#3046 Refs: nodejs/build#2540Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/build#3046 Refs: nodejs/build#2540Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Refs: nodejs/build#3046 Refs: nodejs/build#2540Fixes: #25998 PR-URL: #47233 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
StefanStojanovic
commented
Apr 14, 2023
@RafaelGSS I cannot add a This is my suggestion for the notable-change text: Official support for ARM64 Windows Node.js now includes binaries for ARM64 Windows, allowing for native execution on the platform. The MSI, zip/7z packages, and executable are available from the Node.js download site along with all other platforms. The CI system was updated and all changes are now fully tested on ARM64 Windows, to prevent regressions and ensure compatibility. ARM64 Windows was upgraded to tier 2 support by Stefan Stojanovic on #47233. |
The
notable-change Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. |
Official support for ARM64 Windows is something many people have been looking forward to for years. We recently added test machines to Jenkins, and tests are being run for every PR. We would like to move forward and move ARM64 Windows to tier 2.
@nodejs/build if this PR is approved, @joaocgreis and I will add arm64 to the release Jenkins to start producing releases.
This should land on v19. Node v18 and prior versions have failing tests.
cc @nodejs/tsc @nodejs/platform-windows @nodejs/platform-windows-arm
Refs: nodejs/build#3046
Refs: nodejs/build#2540
Fixes: #25998