Skip to content

tools: fix Slack notification action - #47237

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:notify-invalid-commit
Mar 23, 2023
Merged

tools: fix Slack notification action#47237
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:notify-invalid-commit

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 23, 2023
@aduh95

Copy link
Copy Markdown
ContributorAuthor

I tested it this time: aduh95/node-auto-test#1 (comment)

@debadree25

debadree25 commented Mar 23, 2023

Copy link
Copy Markdown
Contributor

Should we fast-track this? adding the fast-track label for now, feel free to remove if deemed not ncessary

@debadree25debadree25 added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 23, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @debadree25. Please 👍 to approve.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 23, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 946f0ca into nodejs:mainMar 23, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 946f0ca

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
@aduh95
aduh95 deleted the notify-invalid-commit branch April 6, 2023 15:06
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@debadree25@MoLow