Uh oh!
There was an error while loading. Please reload this page.
tools: add scorecard ci - #47254
Merged
Merged
Conversation
nodejs-github-bot
commented
Mar 25, 2023
Collaborator
Review requested:
|
tniessen
commented
Mar 25, 2023
Member
I think we have consciously decided against a variety of available "badges" in the README. I am wondering if this one is helpful to people who come across the README. |
mateonunez
commented
Mar 25, 2023
ContributorAuthor
I see. Also in |
RafaelGSS
approved these changes
Mar 29, 2023
RafaelGSS
commented
Mar 29, 2023
Member
I'm fine removing the badge too. We'll have a report.md in the security-wg. That should be fine. |
RafaelGSS
commented
Mar 29, 2023
Member
@nodejs/security-wg could you please review it? |
RafaelGSS
left a comment
Member
There was a problem hiding this comment.
Can you please fix the commit message? it should be tools: XX (considering you are also removing the badge)
mateonunezforce-pushed
the
feat/add-scorecard
branch
from
March 29, 2023 09:10
98199cc to
1357413Compare4 tasks
RafaelGSS
approved these changes
Mar 29, 2023
fraxken
approved these changes
Mar 30, 2023
nodejs-github-bot
commented
Mar 30, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47254 ✔ Done loading data for nodejs/node/pull/47254 ----------------------------------- PR info ------------------------------------ Title tools: add scorecard ci (#47254) Author Mateo Nunez (@mateonunez, first-time contributor) Branch mateonunez:feat/add-scorecard -> nodejs:main Labels doc, meta Commits 1 - tools: add scorecard workflow Committers 1 - mateonunez PR-URL: https://github.com/nodejs/node/pull/47254 Reviewed-By: Rafael Gonzaga ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47254 Reviewed-By: Rafael Gonzaga -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 25 Mar 2023 15:57:35 GMT ✔ Approvals: 1 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47254#pullrequestreview-1362648093 ✘ This PR needs to wait 49 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4565236989 |
nodejs-github-bot
commented
Mar 30, 2023
Collaborator
Landed in 04cfb82 |
RafaelGSS pushed a commit
that referenced
this pull request
Apr 5, 2023
PR-URL: #47254 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Apr 6, 2023
PR-URL: #47254 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 7, 2023
PR-URL: #47254 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
PR-URL: #47254 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request aims to integrate the
scorecardCI, and to include a badge that exhibits the project's evaluation score as reported in nodejs/security-wg#929.The enhancement of the score will be achieved through the merging of a PR that incorporates the specified version of the actions, as referenced in #46820.