Skip to content

build: avoid usage of pipes library - #47271

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
VoltrexKeyva:avoid-pipes
Mar 29, 2023
Merged

build: avoid usage of pipes library#47271
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
VoltrexKeyva:avoid-pipes

Conversation

@VoltrexKeyva

@VoltrexKeyvaVoltrexKeyva commented Mar 27, 2023

Copy link
Copy Markdown
Contributor

Python's pipes library is deprecated and will be removed in Python version 3.13, so remove it's import and replace pipes.quote() with shlex.quote().

@VoltrexKeyva
build: avoid usage of pipes library
032068a
Python's `pipes` library is deprecated and will be removed in Python
version 3.13, so remove it's import and replace `pipes.quote()` with
`shlex.quote()`.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 27, 2023
@VoltrexKeyvaVoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50641/

@debadree25debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2023
@debadree25debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 29, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ae4f041 into nodejs:mainMar 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2023

Copy link
Copy Markdown
Collaborator

Landed in ae4f041

@VoltrexKeyva
VoltrexKeyva deleted the avoid-pipes branch March 29, 2023 22:02
@RafaelGSSRafaelGSS mentioned this pull request Apr 3, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@VoltrexKeyva@RafaelGSS
build: avoid usage of pipes library
a4418c4
Python's `pipes` library is deprecated and will be removed in Python
version 3.13, so remove it's import and replace `pipes.quote()` with
`shlex.quote()`.
PR-URL: #47271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@VoltrexKeyva@RafaelGSS
build: avoid usage of pipes library
e7d8029
Python's `pipes` library is deprecated and will be removed in Python
version 3.13, so remove it's import and replace `pipes.quote()` with
`shlex.quote()`.
PR-URL: #47271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@VoltrexKeyva@RafaelGSS
build: avoid usage of pipes library
3970537
Python's `pipes` library is deprecated and will be removed in Python
version 3.13, so remove it's import and replace `pipes.quote()` with
`shlex.quote()`.
PR-URL: #47271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@VoltrexKeyva@danielleadams
build: avoid usage of pipes library
67af0a6
Python's `pipes` library is deprecated and will be removed in Python
version 3.13, so remove it's import and replace `pipes.quote()` with
`shlex.quote()`.
PR-URL: #47271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@VoltrexKeyva@nodejs-github-bot@lpinca@anonrig@debadree25