Uh oh!
There was an error while loading. Please reload this page.
meta: clarify the threat model to explain the JSON.parse case - #47276
Merged
Conversation
targos
approved these changes
Mar 28, 2023
anonrig
approved these changes
Mar 28, 2023
cjihrig
approved these changes
Mar 28, 2023
Uh oh!
There was an error while loading. Please reload this page.
tniessen
approved these changes
Mar 28, 2023
Uh oh!
There was an error while loading. Please reload this page.
lpinca
approved these changes
Mar 28, 2023
nodejs-github-bot
commented
Mar 30, 2023
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/47276 ✔ Done loading data for nodejs/node/pull/47276 ----------------------------------- PR info ------------------------------------ Title meta: clarify the threat model to explain the JSON.parse case (#47276) Author Matteo Collina (@mcollina) Branch mcollina:security-model-updates -> nodejs:main Labels doc, author ready Commits 3 - meta: clarify the threat model to explain the JSON.parse case - Update SECURITY.md - Update SECURITY.md Committers 2 - Matteo Collina - GitHub PR-URL: https://github.com/nodejs/node/pull/47276 Reviewed-By: Michaël Zasso Reviewed-By: Yagiz Nizipli Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/47276 Reviewed-By: Michaël Zasso Reviewed-By: Yagiz Nizipli Reviewed-By: Michael Dawson Reviewed-By: Colin Ihrig Reviewed-By: Tobias Nießen Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update SECURITY.md ⚠ - Update SECURITY.md ℹ This PR was created on Tue, 28 Mar 2023 06:50:11 GMT ✔ Approvals: 7 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/47276#pullrequestreview-1360430964 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/47276#pullrequestreview-1360903524 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/47276#pullrequestreview-1361060010 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/47276#pullrequestreview-1361063434 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/47276#pullrequestreview-1361358121 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/47276#pullrequestreview-1361672911 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/47276#pullrequestreview-1361699799 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/4561490045 |
targos
commented
Mar 30, 2023
Member
|
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
commented
Mar 30, 2023
MemberAuthor
Updated, PTAL |
mcollinaforce-pushed
the
security-model-updates
branch
from
March 30, 2023 07:07
621585a to
b1dac8dComparetargos
approved these changes
Mar 30, 2023
nodejs-github-bot
commented
Mar 30, 2023
Collaborator
Landed in 42c4a35 |
RafaelGSS pushed a commit
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #47276 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
RafaelGSS pushed a commit
that referenced
this pull request
Apr 6, 2023
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #47276 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit
that referenced
this pull request
Apr 7, 2023
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #47276 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #47276 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies our threat model to explain that
JSON.parse(str)assumes thatstris trusted.