Uh oh!
There was an error while loading. Please reload this page.
doc: add servername parameter docs - #4729
Closed
estliberitas wants to merge 1 commit into
Closed
Conversation
Add `servername` parameter docs for `https.request()` method. Follows #4389
jasnell
commented
Jan 18, 2016
Member
LGTM |
silverwind
commented
Jan 25, 2016
Contributor
cc: @indutny |
indutny
commented
Jan 25, 2016
Member
Do we have an existing test for this? |
estliberitas
commented
Jan 25, 2016
ContributorAuthor
indutny
commented
Jan 25, 2016
Member
True, LGTM. Thank you! |
silverwind
commented
Jan 25, 2016
Contributor
Thanks! Landed in 8ba5631. |
benjamingr pushed a commit
to benjamingr/io.js
that referenced
this pull request
Jan 27, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
scovetta pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Add `servername` parameter docs for `https.request()` method. Follows nodejs#4389 PR-URL: nodejs#4729 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
servernameparameter docs forhttps.request()method.Follows #4389