Uh oh!
There was an error while loading. Please reload this page.
permission: drop process.permission.deny - #47335
Merged
Merged
Conversation
RafaelGSSforce-pushed
the
drop-permission-deny
branch
from
March 31, 2023 10:53
4aff6eb to
19aacddComparenodejs-github-bot
commented
Mar 31, 2023
Collaborator
RafaelGSSforce-pushed
the
drop-permission-deny
branch
from
March 31, 2023 15:21
19aacdd to
f779526Comparejasnell
approved these changes
Mar 31, 2023
38 tasks
nodejs-github-bot
commented
Apr 1, 2023
Collaborator
aduh95
approved these changes
Apr 1, 2023
aduh95
commented
Apr 1, 2023
Contributor
Seemingly related CI failures on Windows. |
30 tasks
RafaelGSS
commented
Apr 2, 2023
MemberAuthor
Yes, I'll fix it today |
RafaelGSSforce-pushed
the
drop-permission-deny
branch
from
April 2, 2023 19:11
f779526 to
ea8d2ddComparenodejs-github-bot
commented
Apr 2, 2023
Collaborator
RafaelGSSforce-pushed
the
drop-permission-deny
branch
from
April 2, 2023 21:28
ea8d2dd to
2096325Comparenodejs-github-bot
commented
Apr 2, 2023
Collaborator
28 tasks
RafaelGSSforce-pushed
the
drop-permission-deny
branch
from
April 3, 2023 13:08
2096325 to
84ad3bcComparenodejs-github-bot
commented
Apr 3, 2023
Collaborator
This was referenced Apr 3, 2023
BethGriggs
approved these changes
Apr 3, 2023
marco-ippolito
approved these changes
Apr 3, 2023
nodejs-github-bot
commented
Apr 3, 2023
Collaborator
nodejs-github-bot
commented
Apr 3, 2023
Collaborator
29 tasks
nodejs-github-bot
commented
Apr 4, 2023
Collaborator
nodejs-github-bot
commented
Apr 4, 2023
Collaborator
Landed in 6fd147c |
26 tasks
RafaelGSS added a commit
that referenced
this pull request
Apr 13, 2023
PR-URL: #47335 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
abscondment
commented
Jun 16, 2023
@RafaelGSS is there an issue tracking getting this change backported? |
RafaelGSS
commented
Jun 16, 2023
MemberAuthor
Permission Model is only available on Node.js 20. There's no backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed previously in #47105 and #47269. We're dropping the
process.permission.denyAPI to reduce the surface for a potential attack vector.This feature isn't out of our plans, however, we reached a consensus to remove it for further discussion. Also note that this PR isn't a
semver-majorsince the feature (permission model) wasn't released yet.