Skip to content

build: Python pip no longer has a --no-user option - #47338

Merged
cclauss merged 1 commit into
mainfrom
remove_pip_--no-user
Apr 2, 2023
Merged

build: Python pip no longer has a --no-user option#47338
cclauss merged 1 commit into
mainfrom
remove_pip_--no-user

Conversation

@cclauss

@cclausscclauss commented Mar 31, 2023

Copy link
Copy Markdown
Contributor

As discussed in nodejs/build#3273

A --no-user option was added to pip 5 years ago but was later removed.

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 31, 2023
@cclausscclauss added python PRs and issues that require attention from people who are familiar with Python. and removed needs-ci PRs that need a full CI run. labels Mar 31, 2023
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot

This comment was marked as outdated.

@Trott
Trottforce-pushed the remove_pip_--no-user branch from 2948567 to d4653e5CompareMarch 31, 2023 13:54

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cclauss

Copy link
Copy Markdown
ContributorAuthor

Are we OK with the four failing tests?

  • node-test-commit
  • node-test-commit-plinux-rhel8-ppc64le
  • node-test-linux-linked-shared
  • node-test-linux-linked-withoutintl

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@Qard

Qard commented Mar 31, 2023

Copy link
Copy Markdown
Member

I'm guessing those are probably flakes. They don't look related.

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@cclauss
cclauss merged this pull request into mainApr 2, 2023
@cclauss
cclauss deleted the remove_pip_--no-user branch April 2, 2023 05:17
@github-actions

Copy link
Copy Markdown
Contributor

A commit referencing this Pull Request was pushed to by @cclauss without the expected commit metadata added to its message.

@aduh95

aduh95 commented Apr 2, 2023

Copy link
Copy Markdown
Contributor

This landed without the correct metadata, without the required wait time (at the time of writing, this PR needs to wait 5 more hours to land), and without a passing CI (although I'm unsure Jenkins CI is a requirement for this change). I've force-pushed to remove the commit, please open a new PR and use the commit-queueAdd this label to land a pull request using GitHub Actions. label instead of the "Squash and merge" button.

@Trott

Trott commented Apr 2, 2023

Copy link
Copy Markdown
Member

I re-opened this as #47372 (maintaining commit authorship--I think the commit-queue bot sometimes does funny things with it, though, so I might recommend landing manually). I will start CI there and request fast-tracking.

@cclauss

Copy link
Copy Markdown
ContributorAuthor

I sense that the commit message linter did not like that I capitalized the word Python.

In the Python community, we say that python is a snake and Python is a programming language.

@tniessen

Copy link
Copy Markdown
Member

I sense that the commit message linter did not like that I capitalized the word Python.

@cclauss The commit message check that was triggered when you pushed d8e3fca4a521d4ed6def274df75869284785b713 did not fail because of the commit message title. It failed (and sent a warning to the #nodejs-core Slack channel) because you pushed a commit to the main branch that was missing mandatory metadata.

✖ d8e3fca4a521d4ed6def274df75869284785b713
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✖ 0:0 Commit must have a PR-URL. pr-url
✖ 0:0 Commit must have at least 1 reviewer. reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

This PR was also merged in violation of other rules as @aduh95 described above. You can find the collaborator guide here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.pythonPRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@cclauss@nodejs-github-bot@Qard@aduh95@Trott@tniessen@richardlau@MoLow@mhdawson