Skip to content

src: use correct variable in node_builtins.cc - #47343

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-builtins_in_snapshot_js
Apr 11, 2023
Merged

src: use correct variable in node_builtins.cc#47343
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-builtins_in_snapshot_js

Conversation

@targos

@targostargos commented Mar 31, 2023

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 31, 2023
joyeecheung
joyeecheung reviewed Apr 1, 2023
View reviewed changes

@joyeecheungjoyeecheung left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed by making L589 and L595 use builtins_in_snapshot_js instead. Somehow we ended up using builtins_without_cache_js for them, which is technically okay, because it then acts like a temporary handle that gets reused and pointed to another V8 value, but the handle that's meant to be used is actually builtins_in_snapshot_js. Keeping using a handle that's named builtins_without_cache_js for compiledInSnapshot would be confusing.

@targos

targos commented Apr 1, 2023

Copy link
Copy Markdown
MemberAuthor

@joyeecheung feel free to open an alternative PR. Otherwise I'll update this one on Monday

@targos
targos marked this pull request as draft April 1, 2023 07:00
@targos
targos marked this pull request as ready for review April 4, 2023 11:33
@targos
targosforce-pushed the rm-builtins_in_snapshot_js branch from 6cdbeed to eaf854eCompareApril 4, 2023 11:33
@targos

targos commented Apr 4, 2023

Copy link
Copy Markdown
MemberAuthor

Updated

@targostargos changed the title src: remove unused variable in node_builtins.ccsrc: use correct variable in node_builtins.ccApr 4, 2023
@legendecas

legendecas commented Apr 4, 2023

Copy link
Copy Markdown
Member

Though I'm thinking that maybe we don't need three intermediate local handles -- single local handle seems pretty sufficient in the case.

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50948/

@targos

targos commented Apr 5, 2023

Copy link
Copy Markdown
MemberAuthor

BTW, any idea on why the --error-on-warn option only works on node-v8, and not on this repo?

@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51126/

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 25ad49b into nodejs:mainApr 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in 25ad49b

targos added a commit that referenced this pull request May 2, 2023
@targos
src: use correct variable in node_builtins.cc
cda36bf
PR-URL: #47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@targos@danielleadams
src: use correct variable in node_builtins.cc
9f85f35
PR-URL: #47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@targos@MoLow
src: use correct variable in node_builtins.cc
f6aa38d
PR-URL: nodejs#47343
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos@nodejs-github-bot@legendecas@jasnell@lpinca@anonrig@cjihrig@joyeecheung