Skip to content

tools: add a at here tag for slack messages and update variable for default branch - #47358

Closed
debadree25 wants to merge 2 commits into
nodejs:mainfrom
debadree25:ft/add-at-here
Closed

tools: add a at here tag for slack messages and update variable for default branch#47358
debadree25 wants to merge 2 commits into
nodejs:mainfrom
debadree25:ft/add-at-here

Conversation

@debadree25

@debadree25debadree25 commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

Adds a @here to the slack message to notify anyone online

@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@debadree25
debadree25 requested a review from aduh95April 1, 2023 07:12
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 1, 2023
@debadree25
debadree25 requested a review from TrottApril 1, 2023 07:13
aduh95
aduh95 reviewed Apr 1, 2023
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the Slack message, it looks like github.repository.default_branch is an empty string, could we also fix that?

@debadree25

debadree25 commented Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Since the action only runs on the main branch should we just hardcode it? @aduh95

@aduh95

aduh95 commented Apr 1, 2023

Copy link
Copy Markdown
Contributor

I think we should use github.ref that would make more sense here.

@debadree25

debadree25 commented Apr 1, 2023

Copy link
Copy Markdown
ContributorAuthor

Seems like github.ref_name is the variable to use ref: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context

@debadree25debadree25 changed the title tools: add a @here tag for slack messagestools: add a at here tag for slack messagesApr 1, 2023
@debadree25
debadree25 requested a review from aduh95April 1, 2023 09:48
@debadree25debadree25 changed the title tools: add a at here tag for slack messagestools: add a at here tag for slack messages and update variable for default branchApr 1, 2023
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 1, 2023
@debadree25

debadree25 commented Apr 1, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

added rebase tag to land as two separate logic changes one for the @/here and another for the refname

Trott
Trott approved these changes Apr 2, 2023
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I proposed this so I'm definitely in favor. Thanks for doing it! There are over 500 people in that Slack channel and there may be some concern about this being noisy, but I'd prefer we try it and make a determination about it. These kinds of things are exactly the kinds of things I want to be highlighted in that channel, so a notification seems helpful. The other option is to move it to a separate channel, but that risks fragmentation--too many people not bothering to join the alerts channel because they are already in the core channel--that kind of thing.

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5db08cf...81bb1b0

nodejs-github-bot pushed a commit that referenced this pull request Apr 3, 2023
@debadree25@nodejs-github-bot
tools: add a at here tag for slack messages
1265eae
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 3, 2023
@debadree25@nodejs-github-bot
tools: use ref_name to get branch pushed on
81bb1b0
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

This comment was marked as resolved.

Sign in to view
@Trott

Trott commented Apr 3, 2023

Copy link
Copy Markdown
Member

No big deal, but I think this should have used the squash label rather than the rebase label. Not sure if it was a mistake or a difference in landing philosophy.

Eh, nah, looking more closely, it could definitely be rebased. I'm wrong. (Or at least, both approaches are valid here.)

@debadree25

debadree25 commented Apr 3, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

yeah since one changes the message another fixes the bug where the name branch is not appearing hence landing as two. 😅

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@debadree25@RafaelGSS
tools: add a at here tag for slack messages
b9e6584
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
@debadree25@RafaelGSS
tools: use ref_name to get branch pushed on
0fd4793
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@debadree25@RafaelGSS
tools: add a at here tag for slack messages
7bddf7b
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
@debadree25@RafaelGSS
tools: use ref_name to get branch pushed on
1eb15b7
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@debadree25@RafaelGSS
tools: add a at here tag for slack messages
59a9ce3
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
@debadree25@RafaelGSS
tools: use ref_name to get branch pushed on
2febad3
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@debadree25@RafaelGSS
tools: add a at here tag for slack messages
b1d6a15
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
@debadree25@RafaelGSS
tools: use ref_name to get branch pushed on
9c975f7
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@debadree25@danielleadams
tools: add a at here tag for slack messages
59a71f0
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@debadree25@danielleadams
tools: use ref_name to get branch pushed on
9801c15
PR-URL: #47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@debadree25@MoLow
tools: add a at here tag for slack messages
28935a8
PR-URL: nodejs#47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@debadree25@MoLow
tools: use ref_name to get branch pushed on
35e6cf2
PR-URL: nodejs#47358
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-rebaseAdd this label to allow the Commit Queue to land a PR in several commits.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@debadree25@nodejs-github-bot@aduh95@Trott@targos@richardlau