Skip to content

benchmark: fix invalid requirementsURL - #47378

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230403_benchmark_fix_requirementsURL
Apr 3, 2023
Merged

benchmark: fix invalid requirementsURL#47378
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
deokjinkim:230403_benchmark_fix_requirementsURL

Conversation

@deokjinkim

Copy link
Copy Markdown
Contributor

Location of writing-and-running-benchmarks.md is doc/contributing (not benchmark).

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Apr 3, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
@deokjinkim
deokjinkimforce-pushed the 230403_benchmark_fix_requirementsURL branch from 30d760e to 7640c68CompareApril 3, 2023 09:04
@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 3, 2023
@VoltrexKeyvaVoltrexKeyva added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 3, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @VoltrexKeyva. Please 👍 to approve.

@deokjinkimdeokjinkim added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2023
@nodejs-github-bot
nodejs-github-bot merged commit edaa9f4 into nodejs:mainApr 3, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in edaa9f4

RafaelGSS pushed a commit that referenced this pull request Apr 5, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Apr 6, 2023
RafaelGSS pushed a commit that referenced this pull request Apr 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 7, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 8, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: #47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Location of `writing-and-running-benchmarks.md` is `doc/contributing`
(not benchmark).
PR-URL: nodejs#47378
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@deokjinkim@nodejs-github-bot@lpinca@anonrig@VoltrexKeyva