Skip to content

tools: move update-acorn.sh to dep_updaters - #47382

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/update-acorn
Apr 10, 2023
Merged

tools: move update-acorn.sh to dep_updaters#47382
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/update-acorn

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Apr 3, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
@nodejs/security-wg

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 3, 2023
@targos

Copy link
Copy Markdown
Member

Can you please make the commit message clearer?

Comment threadtools/dep_updaters/update-acorn.sh Outdated
Comment threadtools/dep_updaters/update-acorn-walk.sh Outdated
@marco-ippolitomarco-ippolito changed the title tools: maintaining acorntools: move update-acorn.sh to dep_updatersApr 3, 2023

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 7, 2023
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c2b54fb into nodejs:mainApr 10, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c2b54fb

RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
PR-URL: #47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47382
Refs: nodejs/security-wg#828
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@marco-ippolito@nodejs-github-bot@targos@ShogunPanda@lpinca@RafaelGSS