Skip to content

crypto: replace THROW with CHECK for scrypt keylen - #47407

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:crypto-scrypt-keylen-check
Apr 9, 2023
Merged

crypto: replace THROW with CHECK for scrypt keylen#47407
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:crypto-scrypt-keylen-check

Conversation

@tniessen

@tniessentniessen commented Apr 4, 2023

Copy link
Copy Markdown
Member

The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure that the keylen argument fits into a signed 32-bit integer, thus, the THROW statement in C++ is unreachable (unless the binding is accessed directly, of course).

node/lib/internal/crypto/scrypt.js

Lines 85 to 91 in af8ed02

functioncheck(password,salt,keylen,options){
if(ScryptJob===undefined)
thrownewERR_CRYPTO_SCRYPT_NOT_SUPPORTED();
password=getArrayBufferOrView(password,'password');
salt=getArrayBufferOrView(salt,'salt');
validateInt32(keylen,'keylen',0);

@tniessen
crypto: replace THROW with CHECK for scrypt keylen
46631b5
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 4, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 4, 2023
@panvapanva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 4, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 4, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50943/

@github-actionsgithub-actionsBot mentioned this pull request Apr 5, 2023
Open
26 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51066/

@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51070/

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1cda3f3 into nodejs:mainApr 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1cda3f3

@RafaelGSSRafaelGSS mentioned this pull request Apr 11, 2023
Merged
@github-actionsgithub-actionsBot mentioned this pull request Apr 12, 2023
Open
31 tasks
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@tniessen@RafaelGSS
crypto: replace THROW with CHECK for scrypt keylen
48c0148
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).
PR-URL: #47407
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen@danielleadams
crypto: replace THROW with CHECK for scrypt keylen
ac3a4d9
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).
PR-URL: #47407
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen@MoLow
crypto: replace THROW with CHECK for scrypt keylen
a5f214c
The JS layer already uses validateInt32(keylen, 'keylen', 0) to ensure
that the keylen argument fits into a signed 32-bit integer, thus, the
THROW statement in C++ is unreachable (unless the binding is accessed
directly, of course).
PR-URL: nodejs#47407
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen@nodejs-github-bot@panva@lpinca@anonrig