url: more sophisticated brand check for URLSearchParams by TimothyGu · Pull Request #47414 · nodejs/node

TimothyGu · 2023-04-05T03:19:02Z

Use private properties, following the lead of the URL class.

nodejs-github-bot · 2023-04-05T03:19:06Z

Review requested:

@nodejs/url

anonrig · 2023-04-05T12:01:09Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1321/

Trott · 2023-04-07T00:06:58Z

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1321/

Results are very good IMO:

confidence improvement accuracy (*) (**) (***)
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='auth' 0.51 % ±1.99% ±2.65% ±3.45%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='dot' -1.72 % ±3.33% ±4.44% ±5.78%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='file' -2.65 % ±2.78% ±3.70% ±4.82%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='idn' -0.13 % ±2.35% ±3.12% ±4.06%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='javascript' -3.52 % ±3.96% ±5.27% ±6.86%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='long' -1.07 % ±3.38% ±4.52% ±5.92%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='percent' -0.45 % ±3.85% ±5.12% ±6.67%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='short' 1.79 % ±2.76% ±3.67% ±4.78%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='wpt' -2.31 % ±3.17% ±4.23% ±5.52%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='legacy' type='ws' -0.21 % ±2.69% ±3.58% ±4.66%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='auth' -5.71 % ±5.99% ±7.98% ±10.39%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='dot' * 10.86 % ±10.49% ±13.96% ±18.18%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='file' * -11.00 % ±10.87% ±14.46% ±18.82%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='idn' -1.87 % ±8.13% ±10.82% ±14.08%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='javascript' 7.14 % ±12.47% ±16.60% ±21.61%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='long' -1.37 % ±3.92% ±5.22% ±6.80%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='percent' 7.69 % ±10.03% ±13.35% ±17.39%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='short' 0.30 % ±11.13% ±14.81% ±19.28%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='wpt' -1.11 % ±3.10% ±4.17% ±5.52%
10:18:04 url/legacy-vs-whatwg-url-get-prop.js e=1 method='whatwg' type='ws' -0.75 % ±5.51% ±7.34% ±9.55%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='auth' withBase='false' -0.01 % ±2.85% ±3.79% ±4.95%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='auth' withBase='true' 1.01 % ±2.43% ±3.24% ±4.22%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='dot' withBase='false' 1.58 % ±4.46% ±5.94% ±7.75%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='dot' withBase='true' 0.99 % ±2.92% ±3.89% ±5.06%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='file' withBase='false' 2.48 % ±4.55% ±6.06% ±7.90%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='file' withBase='true' 1.09 % ±4.28% ±5.70% ±7.41%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='idn' withBase='false' -1.78 % ±4.14% ±5.51% ±7.18%
10:18:04 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='idn' withBase='true' 0.69 % ±4.27% ±5.68% ±7.40%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='javascript' withBase='false' -0.98 % ±5.38% ±7.16% ±9.32%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='javascript' withBase='true' -0.03 % ±5.97% ±7.94% ±10.34%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='long' withBase='false' -0.35 % ±1.42% ±1.89% ±2.46%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='long' withBase='true' -0.86 % ±1.29% ±1.71% ±2.23%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='percent' withBase='false' -3.91 % ±5.61% ±7.47% ±9.74%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='percent' withBase='true' -1.67 % ±5.13% ±6.83% ±8.89%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='short' withBase='false' 2.86 % ±3.47% ±4.61% ±6.01%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='short' withBase='true' 1.05 % ±3.51% ±4.66% ±6.07%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='wpt' withBase='false' -0.13 % ±1.33% ±1.77% ±2.31%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='wpt' withBase='true' -0.45 % ±1.08% ±1.44% ±1.87%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='ws' withBase='false' -1.60 % ±2.15% ±2.87% ±3.75%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='legacy' e=1 type='ws' withBase='true' -1.19 % ±2.41% ±3.20% ±4.17%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='auth' withBase='false' 3.60 % ±11.66% ±15.51% ±20.19%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='auth' withBase='true' 7.44 % ±11.25% ±14.97% ±19.48%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='dot' withBase='false' -3.30 % ±11.57% ±15.40% ±20.04%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='dot' withBase='true' -1.22 % ±11.45% ±15.24% ±19.84%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='file' withBase='false' 5.59 % ±13.42% ±17.85% ±23.24%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='file' withBase='true' 3.02 % ±11.88% ±15.81% ±20.59%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='idn' withBase='false' 2.65 % ±11.69% ±15.55% ±20.25%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='idn' withBase='true' 6.33 % ±10.04% ±13.36% ±17.39%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='javascript' withBase='false' * 10.93 % ±10.40% ±13.84% ±18.01%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='javascript' withBase='true' -7.98 % ±10.78% ±14.35% ±18.68%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='long' withBase='false' -3.68 % ±7.76% ±10.32% ±13.43%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='long' withBase='true' * -7.63 % ±6.54% ±8.70% ±11.33%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='percent' withBase='false' 0.66 % ±11.65% ±15.50% ±20.17%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='percent' withBase='true' 5.41 % ±11.45% ±15.24% ±19.83%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='short' withBase='false' -1.73 % ±12.39% ±16.49% ±21.46%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='short' withBase='true' 5.04 % ±12.52% ±16.66% ±21.68%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='wpt' withBase='false' -0.38 % ±1.93% ±2.57% ±3.34%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='wpt' withBase='true' 3.43 % ±3.92% ±5.22% ±6.81%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='ws' withBase='false' -8.02 % ±10.91% ±14.52% ±18.90%
10:18:05 url/legacy-vs-whatwg-url-parse.js method='whatwg' e=1 type='ws' withBase='true' 6.64 % ±12.55% ±16.70% ±21.73%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='altspaces' 0.94 % ±4.97% ±6.62% ±8.61%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='encodefake' -2.39 % ±6.00% ±7.98% ±10.39%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='encodelast' -1.03 % ±6.13% ±8.15% ±10.61%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='encodemany' -4.59 % ±4.71% ±6.27% ±8.16%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='manyblankpairs' 2.25 % ±6.40% ±8.51% ±11.08%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='manypairs' -0.53 % ±2.37% ±3.15% ±4.10%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='multicharsep' 1.27 % ±4.81% ±6.41% ±8.35%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='multivalue' 1.69 % ±6.64% ±8.84% ±11.50%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='multivaluemany' -0.81 % ±3.80% ±5.06% ±6.58%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='legacy' searchParam='noencode' * 7.60 % ±6.38% ±8.49% ±11.06%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='altspaces' 1.20 % ±1.81% ±2.41% ±3.14%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='encodefake' -1.59 % ±3.16% ±4.21% ±5.48%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='encodelast' 1.28 % ±1.75% ±2.33% ±3.04%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='encodemany' 1.15 % ±2.40% ±3.21% ±4.20%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='manyblankpairs' -4.36 % ±5.30% ±7.06% ±9.22%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='manypairs' 0.49 % ±2.67% ±3.56% ±4.65%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multicharsep' -1.84 % ±2.74% ±3.66% ±4.78%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multivalue' -0.05 % ±2.95% ±3.93% ±5.12%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multivaluemany' -1.04 % ±2.54% ±3.39% ±4.42%
10:18:05 url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='noencode' -1.08 % ±3.20% ±4.26% ±5.54%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='altspaces' -1.14 % ±1.94% ±2.60% ±3.40%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='encodefake' 1.79 % ±2.74% ±3.65% ±4.79%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='encodelast' -0.38 % ±3.04% ±4.05% ±5.27%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='encodemany' -0.08 % ±2.31% ±3.08% ±4.05%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='manyblankpairs' 0.90 % ±4.97% ±6.62% ±8.61%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='manypairs' -0.48 % ±1.85% ±2.47% ±3.22%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='multicharsep' -0.92 % ±2.54% ±3.39% ±4.41%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='multivalue' 0.31 % ±2.54% ±3.38% ±4.41%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='multivaluemany' -2.51 % ±3.15% ±4.21% ±5.51%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='legacy' searchParam='noencode' 0.30 % ±1.27% ±1.69% ±2.19%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='altspaces' 0.26 % ±2.15% ±2.86% ±3.72%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='encodefake' * 2.93 % ±2.91% ±3.87% ±5.04%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='encodelast' 1.25 % ±4.62% ±6.15% ±8.01%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='encodemany' 1.13 % ±2.80% ±3.72% ±4.84%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='manyblankpairs' *** 53.22 % ±5.92% ±7.90% ±10.34%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='manypairs' * -1.83 % ±1.38% ±1.85% ±2.43%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='multicharsep' 1.93 % ±4.08% ±5.43% ±7.07%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='multivalue' 1.73 % ±3.54% ±4.71% ±6.13%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='multivaluemany' 1.30 % ±2.33% ±3.12% ±4.11%
10:18:05 url/legacy-vs-whatwg-url-searchparams-serialize.js n=1000000 method='whatwg' searchParam='noencode' 0.37 % ±3.72% ±4.95% ±6.45%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='auth' 4.69 % ±11.15% ±14.84% ±19.31%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='dot' -0.76 % ±11.99% ±15.95% ±20.76%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='file' -8.61 % ±11.10% ±14.77% ±19.23%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='idn' 0.89 % ±10.85% ±14.43% ±18.78%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='javascript' 4.72 % ±11.94% ±15.90% ±20.72%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='long' 7.94 % ±12.56% ±16.71% ±21.75%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='percent' -0.97 % ±11.58% ±15.41% ±20.06%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='short' -0.37 % ±11.63% ±15.48% ±20.16%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='wpt' 0.02 % ±3.94% ±5.25% ±6.86%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='legacy' type='ws' 8.57 % ±10.98% ±14.60% ±19.01%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='auth' 4.98 % ±13.58% ±18.07% ±23.54%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='dot' 0.49 % ±12.74% ±16.95% ±22.07%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='file' -8.19 % ±11.72% ±15.62% ±20.36%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='idn' -0.68 % ±12.54% ±16.69% ±21.73%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='javascript' -3.80 % ±11.01% ±14.65% ±19.07%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='long' 0.62 % ±12.89% ±17.16% ±22.33%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='percent' 2.34 % ±11.64% ±15.49% ±20.16%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='short' 1.05 % ±12.37% ±16.47% ±21.45%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='wpt' 0.84 % ±2.98% ±3.96% ±5.16%
10:18:05 url/legacy-vs-whatwg-url-serialize.js e=1 method='whatwg' type='ws' -7.14 % ±11.04% ±14.68% ±19.11%
10:18:05 url/url-format.js n=25000000 type='file' 0.81 % ±1.69% ±2.25% ±2.95%
10:18:05 url/url-format.js n=25000000 type='slashes' -0.41 % ±2.17% ±2.88% ±3.75%
10:18:05 url/url-parse.js n=10000000 type='escaped' 0.08 % ±2.81% ±3.74% ±4.88%
10:18:05 url/url-parse.js n=10000000 type='normal' 2.39 % ±3.63% ±4.83% ±6.28%
10:18:05 url/url-resolve.js n=100000 path='down' href='auth' -0.99 % ±2.35% ±3.13% ±4.08%
10:18:05 url/url-resolve.js n=100000 path='down' href='dot' -1.06 % ±2.73% ±3.64% ±4.75%
10:18:05 url/url-resolve.js n=100000 path='down' href='file' 0.35 % ±2.52% ±3.35% ±4.36%
10:18:05 url/url-resolve.js n=100000 path='down' href='idn' -1.18 % ±3.88% ±5.17% ±6.73%
10:18:05 url/url-resolve.js n=100000 path='down' href='javascript' -1.35 % ±2.90% ±3.86% ±5.03%
10:18:05 url/url-resolve.js n=100000 path='down' href='long' 1.87 % ±2.61% ±3.48% ±4.55%
10:18:05 url/url-resolve.js n=100000 path='down' href='noscheme' 0.55 % ±2.85% ±3.79% ±4.94%
10:18:05 url/url-resolve.js n=100000 path='down' href='percent' 2.01 % ±2.76% ±3.68% ±4.80%
10:18:05 url/url-resolve.js n=100000 path='down' href='short' 1.76 % ±2.31% ±3.08% ±4.01%
10:18:05 url/url-resolve.js n=100000 path='down' href='ws' 2.23 % ±2.78% ±3.70% ±4.82%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='auth' * -2.33 % ±2.26% ±3.00% ±3.91%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='dot' -0.10 % ±2.68% ±3.57% ±4.66%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='file' 2.28 % ±2.57% ±3.42% ±4.45%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='idn' 0.53 % ±3.70% ±4.93% ±6.42%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='javascript' -0.15 % ±2.75% ±3.66% ±4.76%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='long' 0.57 % ±1.75% ±2.34% ±3.05%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='noscheme' -1.29 % ±2.60% ±3.46% ±4.50%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='percent' 0.46 % ±3.08% ±4.10% ±5.35%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='short' * -2.85 % ±2.79% ±3.71% ±4.83%
10:18:05 url/url-resolve.js n=100000 path='foo/bar' href='ws' 1.31 % ±2.41% ±3.21% ±4.19%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='auth' 0.77 % ±2.99% ±4.00% ±5.25%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='dot' -1.94 % ±2.52% ±3.35% ±4.37%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='file' 0.04 % ±2.24% ±2.99% ±3.90%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='idn' 2.26 % ±3.23% ±4.29% ±5.59%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='javascript' * 3.60 % ±2.76% ±3.68% ±4.80%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='long' -1.25 % ±2.33% ±3.10% ±4.04%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='noscheme' 0.13 % ±2.81% ±3.73% ±4.86%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='percent' 1.39 % ±2.67% ±3.55% ±4.62%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='short' 1.69 % ±2.90% ±3.86% ±5.02%
10:18:05 url/url-resolve.js n=100000 path='sibling' href='ws' -0.46 % ±2.56% ±3.41% ±4.43%
10:18:05 url/url-resolve.js n=100000 path='up' href='auth' * -3.09 % ±2.98% ±3.99% ±5.25%
10:18:05 url/url-resolve.js n=100000 path='up' href='dot' 1.89 % ±2.27% ±3.02% ±3.93%
10:18:05 url/url-resolve.js n=100000 path='up' href='file' -2.12 % ±2.80% ±3.73% ±4.86%
10:18:05 url/url-resolve.js n=100000 path='up' href='idn' -1.07 % ±3.44% ±4.58% ±5.97%
10:18:05 url/url-resolve.js n=100000 path='up' href='javascript' -1.43 % ±3.07% ±4.09% ±5.33%
10:18:05 url/url-resolve.js n=100000 path='up' href='long' 0.96 % ±1.37% ±1.82% ±2.37%
10:18:05 url/url-resolve.js n=100000 path='up' href='noscheme' * -3.20 % ±2.79% ±3.71% ±4.84%
10:18:05 url/url-resolve.js n=100000 path='up' href='percent' 1.63 % ±2.57% ±3.42% ±4.45%
10:18:05 url/url-resolve.js n=100000 path='up' href='short' 1.33 % ±2.21% ±2.94% ±3.84%
10:18:05 url/url-resolve.js n=100000 path='up' href='ws' -0.99 % ±2.36% ±3.14% ±4.09%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='auth' * -3.79 % ±2.93% ±3.90% ±5.07%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='dot' 0.81 % ±2.80% ±3.74% ±4.89%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='file' * 2.81 % ±2.35% ±3.13% ±4.08%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='idn' -2.88 % ±3.18% ±4.23% ±5.50%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='javascript' 2.09 % ±3.36% ±4.47% ±5.81%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='long' 0.65 % ±2.07% ±2.75% ±3.58%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='noscheme' -0.38 % ±2.86% ±3.81% ±4.96%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='percent' -0.37 % ±3.52% ±4.69% ±6.10%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='short' * 2.70 % ±2.53% ±3.37% ±4.40%
10:18:05 url/url-resolve.js n=100000 path='withscheme' href='ws' 2.16 % ±2.73% ±3.63% ±4.73%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='iterable' type='array' 0.48 % ±1.65% ±2.20% ±2.86%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='iterable' type='encodelast' -0.55 % ±4.04% ±5.38% ±7.00%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='iterable' type='encodemany' 0.55 % ±3.66% ±4.87% ±6.34%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='iterable' type='multiprimitives' 0.97 % ±3.61% ±4.80% ±6.26%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='iterable' type='noencode' -2.55 % ±3.50% ±4.66% ±6.06%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='object' type='array' 0.63 % ±2.19% ±2.93% ±3.85%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='object' type='encodelast' 0.76 % ±2.34% ±3.12% ±4.06%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='object' type='encodemany' 0.58 % ±2.51% ±3.36% ±4.39%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='object' type='multiprimitives' * -2.79 % ±2.24% ±2.98% ±3.88%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='object' type='noencode' -0.39 % ±2.29% ±3.04% ±3.96%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='string' type='array' 2.33 % ±3.01% ±4.01% ±5.22%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='string' type='encodelast' 0.21 % ±3.76% ±5.01% ±6.53%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='string' type='encodemany' 1.53 % ±3.33% ±4.44% ±5.80%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='string' type='multiprimitives' 0.67 % ±3.32% ±4.43% ±5.78%
10:18:05 url/url-searchparams-creation.js n=1000000 inputType='string' type='noencode' 2.32 % ±2.87% ±3.81% ±4.97%
10:18:05 url/url-searchparams-iteration.js n=1000000 loopMethod='forEach' 3.87 % ±4.16% ±5.59% ±7.37%
10:18:05 url/url-searchparams-iteration.js n=1000000 loopMethod='iterator' *** 36.66 % ±5.21% ±6.94% ±9.07%
10:18:05 url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='get' * 3.51 % ±2.68% ±3.59% ±4.72%
10:18:05 url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='getAll' *** 4.99 % ±1.05% ±1.40% ±1.83%
10:18:05 url/url-searchparams-read.js n=20000000 param='nonexistent' accessMethod='has' *** 4.49 % ±1.70% ±2.26% ±2.95%
10:18:05 url/url-searchparams-read.js n=20000000 param='one' accessMethod='get' *** 4.19 % ±1.53% ±2.04% ±2.66%
10:18:05 url/url-searchparams-read.js n=20000000 param='one' accessMethod='getAll' -0.21 % ±4.23% ±5.70% ±7.55%
10:18:05 url/url-searchparams-read.js n=20000000 param='one' accessMethod='has' *** 7.21 % ±3.69% ±4.92% ±6.40%
10:18:05 url/url-searchparams-read.js n=20000000 param='three' accessMethod='get' -0.56 % ±3.35% ±4.50% ±5.92%
10:18:05 url/url-searchparams-read.js n=20000000 param='three' accessMethod='getAll' *** 1.82 % ±0.70% ±0.93% ±1.21%
10:18:05 url/url-searchparams-read.js n=20000000 param='three' accessMethod='has' 0.14 % ±1.94% ±2.58% ±3.37%
10:18:05 url/url-searchparams-read.js n=20000000 param='two' accessMethod='get' 1.79 % ±3.51% ±4.71% ±6.22%
10:18:05 url/url-searchparams-read.js n=20000000 param='two' accessMethod='getAll' ** 1.55 % ±0.94% ±1.25% ±1.63%
10:18:06 url/url-searchparams-read.js n=20000000 param='two' accessMethod='has' -0.51 % ±2.75% ±3.69% ±4.87%
10:18:06 url/url-searchparams-sort.js n=1000000 type='almostsorted' -1.72 % ±5.08% ±6.79% ±8.90%
10:18:06 url/url-searchparams-sort.js n=1000000 type='empty' -2.54 % ±4.17% ±5.55% ±7.23%
10:18:06 url/url-searchparams-sort.js n=1000000 type='long' -2.08 % ±3.58% ±4.76% ±6.20%
10:18:06 url/url-searchparams-sort.js n=1000000 type='random' -0.40 % ±4.28% ±5.69% ±7.41%
10:18:06 url/url-searchparams-sort.js n=1000000 type='reversed' 0.87 % ±7.37% ±9.81% ±12.77%
10:18:06 url/url-searchparams-sort.js n=1000000 type='short' 0.93 % ±7.14% ±9.52% ±12.44%
10:18:06 url/url-searchparams-sort.js n=1000000 type='sorted' -1.35 % ±3.80% ±5.09% ±6.68%
10:18:06 url/url-searchparams-sort.js n=1000000 type='wpt' -5.59 % ±5.85% ±7.81% ±10.23%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='iterable' type='array' ** 4.83 % ±2.95% ±3.94% ±5.15%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='iterable' type='encodelast' -1.26 % ±3.76% ±5.00% ±6.51%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='iterable' type='encodemany' -1.09 % ±2.29% ±3.04% ±3.96%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='iterable' type='multiprimitives' 1.60 % ±4.38% ±5.83% ±7.59%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='iterable' type='noencode' * -3.82 % ±3.75% ±5.01% ±6.55%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='object' type='array' 0.79 % ±3.19% ±4.24% ±5.52%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='object' type='encodelast' 0.11 % ±4.35% ±5.79% ±7.55%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='object' type='encodemany' -0.32 % ±2.45% ±3.26% ±4.24%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='object' type='multiprimitives' 3.84 % ±4.17% ±5.55% ±7.24%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='object' type='noencode' -1.46 % ±3.92% ±5.22% ±6.80%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='string' type='array' -1.56 % ±3.10% ±4.13% ±5.38%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='string' type='encodelast' 0.20 % ±3.28% ±4.36% ±5.68%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='string' type='encodemany' 1.82 % ±3.09% ±4.11% ±5.36%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='string' type='multiprimitives' 2.07 % ±3.39% ±4.51% ±5.89%
10:18:06 url/url-searchparams-toString.js n=1000000 inputType='string' type='noencode' -0.00 % ±3.56% ±4.74% ±6.18%
10:18:06 url/usvstring.js n=50000000 input='allinvalid' 1.42 % ±1.82% ±2.43% ±3.19%
10:18:06 url/usvstring.js n=50000000 input='nonstring' -0.43 % ±1.57% ±2.08% ±2.72%
10:18:06 url/usvstring.js n=50000000 input='someinvalid' -0.29 % ±2.03% ±2.71% ±3.52%
10:18:06 url/usvstring.js n=50000000 input='valid' -1.19 % ±3.58% ±4.81% ±6.34%
10:18:06 url/usvstring.js n=50000000 input='validsurr' -0.11 % ±1.81% ±2.41% ±3.15%
10:18:06 url/whatwg-url-idna.js n=5000000 to='ascii' domain='all' 0.44 % ±3.84% ±5.11% ±6.65%
10:18:06 url/whatwg-url-idna.js n=5000000 to='ascii' domain='empty' 1.00 % ±2.99% ±3.98% ±5.18%
10:18:06 url/whatwg-url-idna.js n=5000000 to='ascii' domain='none' -0.93 % ±2.17% ±2.89% ±3.78%
10:18:06 url/whatwg-url-idna.js n=5000000 to='ascii' domain='nonstring' -1.90 % ±3.39% ±4.52% ±5.90%
10:18:06 url/whatwg-url-idna.js n=5000000 to='ascii' domain='some' 1.18 % ±3.95% ±5.25% ±6.84%
10:18:06 url/whatwg-url-idna.js n=5000000 to='unicode' domain='all' -0.49 % ±3.67% ±4.88% ±6.35%
10:18:06 url/whatwg-url-idna.js n=5000000 to='unicode' domain='empty' -0.20 % ±2.34% ±3.12% ±4.07%
10:18:06 url/whatwg-url-idna.js n=5000000 to='unicode' domain='none' -0.16 % ±3.77% ±5.02% ±6.54%
10:18:06 url/whatwg-url-idna.js n=5000000 to='unicode' domain='nonstring' -1.69 % ±3.88% ±5.16% ±6.72%
10:18:06 url/whatwg-url-idna.js n=5000000 to='unicode' domain='some' 0.48 % ±3.41% ±4.53% ±5.90%
10:18:06 url/whatwg-url-properties.js prop='hash' e=1 type='wpt' withBase='false' * -3.61 % ±3.42% ±4.56% ±5.96%
10:18:06 url/whatwg-url-properties.js prop='hash' e=1 type='wpt' withBase='true' -0.44 % ±3.02% ±4.03% ±5.24%
10:18:06 url/whatwg-url-properties.js prop='host' e=1 type='wpt' withBase='false' -1.08 % ±5.05% ±6.76% ±8.89%
10:18:06 url/whatwg-url-properties.js prop='host' e=1 type='wpt' withBase='true' -1.81 % ±5.17% ±6.90% ±9.02%
10:18:06 url/whatwg-url-properties.js prop='hostname' e=1 type='wpt' withBase='false' -0.29 % ±3.41% ±4.53% ±5.90%
10:18:06 url/whatwg-url-properties.js prop='hostname' e=1 type='wpt' withBase='true' -1.39 % ±2.31% ±3.07% ±4.00%
10:18:06 url/whatwg-url-properties.js prop='href' e=1 type='wpt' withBase='false' -1.40 % ±5.82% ±7.78% ±10.21%
10:18:06 url/whatwg-url-properties.js prop='href' e=1 type='wpt' withBase='true' 1.51 % ±2.72% ±3.65% ±4.81%
10:18:06 url/whatwg-url-properties.js prop='origin' e=1 type='wpt' withBase='false' 0.20 % ±4.15% ±5.53% ±7.22%
10:18:06 url/whatwg-url-properties.js prop='origin' e=1 type='wpt' withBase='true' 2.47 % ±5.14% ±6.85% ±8.93%
10:18:06 url/whatwg-url-properties.js prop='password' e=1 type='wpt' withBase='false' 0.02 % ±3.35% ±4.46% ±5.81%
10:18:06 url/whatwg-url-properties.js prop='password' e=1 type='wpt' withBase='true' -0.92 % ±4.07% ±5.42% ±7.07%
10:18:06 url/whatwg-url-properties.js prop='pathname' e=1 type='wpt' withBase='false' -1.28 % ±2.44% ±3.25% ±4.23%
10:18:06 url/whatwg-url-properties.js prop='pathname' e=1 type='wpt' withBase='true' 0.31 % ±3.12% ±4.15% ±5.40%
10:18:06 url/whatwg-url-properties.js prop='port' e=1 type='wpt' withBase='false' -0.80 % ±3.46% ±4.61% ±6.01%
10:18:06 url/whatwg-url-properties.js prop='port' e=1 type='wpt' withBase='true' -1.47 % ±3.84% ±5.12% ±6.69%
10:18:06 url/whatwg-url-properties.js prop='protocol' e=1 type='wpt' withBase='false' -0.12 % ±3.43% ±4.57% ±5.95%
10:18:06 url/whatwg-url-properties.js prop='protocol' e=1 type='wpt' withBase='true' -1.60 % ±4.69% ±6.27% ±8.23%
10:18:06 url/whatwg-url-properties.js prop='search' e=1 type='wpt' withBase='false' 0.03 % ±4.11% ±5.47% ±7.15%
10:18:06 url/whatwg-url-properties.js prop='search' e=1 type='wpt' withBase='true' -2.46 % ±4.08% ±5.44% ±7.10%
10:18:06 url/whatwg-url-properties.js prop='searchParams' e=1 type='wpt' withBase='false' -3.24 % ±4.22% ±5.63% ±7.36%
10:18:06 url/whatwg-url-properties.js prop='searchParams' e=1 type='wpt' withBase='true' *** 13.02 % ±2.15% ±2.87% ±3.73%
10:18:06 url/whatwg-url-properties.js prop='username' e=1 type='wpt' withBase='false' 0.80 % ±3.62% ±4.83% ±6.31%
10:18:06 url/whatwg-url-properties.js prop='username' e=1 type='wpt' withBase='true' 0.03 % ±3.79% ±5.07% ±6.66%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='auth' -0.08 % ±4.09% ±5.44% ±7.08%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='dot' * 4.57 % ±4.36% ±5.80% ±7.56%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='file' 1.13 % ±3.35% ±4.46% ±5.81%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='idn' 2.51 % ±3.94% ±5.25% ±6.84%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='javascript' -1.50 % ±3.31% ±4.41% ±5.75%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='long' 0.19 % ±2.49% ±3.32% ±4.33%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='percent' 1.88 % ±3.38% ±4.49% ±5.85%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='short' 0.43 % ±2.74% ±3.65% ±4.75%
10:18:06 url/whatwgurl-canParse.js n=1000000 type='ws' 1.56 % ±3.52% ±4.69% ±6.10%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='fileURLToPath' input='file:///dev/null?key=param&bool' 0.33 % ±2.69% ±3.58% ±4.67%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='fileURLToPath' input='file:///dev/null?key=param&bool#hash' 1.26 % ±2.32% ±3.09% ±4.02%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='fileURLToPath' input='file:///dev/null' 0.20 % ±2.25% ±3.00% ±3.90%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='pathToFileURL' input='file:///dev/null?key=param&bool' 1.99 % ±2.15% ±2.86% ±3.72%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='pathToFileURL' input='file:///dev/null?key=param&bool#hash' 1.94 % ±2.22% ±2.95% ±3.85%
10:18:06 url/whatwgurl-to-and-from-path.js n=5000000 method='pathToFileURL' input='file:///dev/null' -2.03 % ±2.26% ±3.01% ±3.93%
10:18:06 10:18:06 Be aware that when doing many comparisons the risk of a false-positive
10:18:06 result increases. In this case, there are 280 comparisons, you can thus
10:18:06 expect the following amount of false-positive results:
10:18:06 14.00 false positives, when considering a 5% risk acceptance (*, **, ***),
10:18:06 2.80 false positives, when considering a 1% risk acceptance (**, ***),
10:18:06 0.28 false positives, when considering a 0.1% risk acceptance (***)

TimothyGu · 2023-04-07T01:30:48Z

The performance impact might be because this.#abc doesn't ever traverse up the prototype chain. But the performance aspect is definitely not the focus of this PR.

Also since this PR doesn't change the status quo, I propose that we not block it on the resolution from #47218.

nodejs-github-bot · 2023-04-07T04:29:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51035/

nodejs-github-bot · 2023-04-07T17:18:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/51053/

Use private properties and static {} blocks. PR-URL: nodejs#47414 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott · 2023-04-07T19:00:32Z

Landed in 4b448c8

Use private properties and static {} blocks. PR-URL: #47414 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

TimothyGu requested a review from anonrig April 5, 2023 03:19

nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 5, 2023

TimothyGu added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023

This comment was marked as outdated.
Sign in to view

anonrig reviewed Apr 5, 2023
View reviewed changes

Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated
Comment threadlib/internal/url.js Outdated

TimothyGu force-pushed the url-brand branch from e913dfe to 19c7711Compare April 5, 2023 19:11

anonrig approved these changes Apr 6, 2023
View reviewed changes

benjamingr approved these changes Apr 6, 2023
View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 6, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023

Trott approved these changes Apr 7, 2023
View reviewed changes

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

nodejs deleted a comment from nodejs-github-bot Apr 7, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

This comment was marked as outdated.
Sign in to view

TimothyGu force-pushed the url-brand branch from 19c7711 to f0544b2Compare April 7, 2023 04:17

TimothyGu added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 7, 2023

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2023

url: more sophisticated brand check for URLSearchParams
4b448c8
Use private properties and static {} blocks. PR-URL: nodejs#47414 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott force-pushed the url-brand branch from f0544b2 to 4b448c8Compare April 7, 2023 18:59

Trott merged commit 4b448c8 into nodejs:mainApr 7, 2023

TimothyGu deleted the url-brand branch April 8, 2023 00:06

RafaelGSS mentioned this pull request Apr 11, 2023
2023-04-18, Version 20.0.0 (Current) #47381
Merged

danielleadams added the backport-requested-v18.x label Jun 12, 2023

panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024

Navigation Menu

Uh oh!

Uh oh!

url: more sophisticated brand check for URLSearchParams - #47414

url: more sophisticated brand check for URLSearchParams#47414
Trott merged 1 commit into
nodejs:mainfrom
TimothyGu:url-brand

TimothyGu commented Apr 5, 2023•
edited
Loading

Uh oh!

nodejs-github-bot commented Apr 5, 2023•
edited by TimothyGu
Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrig commented Apr 5, 2023

Uh oh!

Trott commented Apr 7, 2023•
edited
Loading

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

TimothyGu commented Apr 7, 2023

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Apr 7, 2023

Uh oh!

nodejs-github-bot commented Apr 7, 2023

Uh oh!

Trott commented Apr 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

TimothyGu commented Apr 5, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 5, 2023• edited by TimothyGu Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrig commented Apr 5, 2023

Uh oh!

Trott commented Apr 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

TimothyGu commented Apr 7, 2023

Uh oh!

This comment was marked as outdated.

nodejs-github-bot commented Apr 7, 2023

Uh oh!

nodejs-github-bot commented Apr 7, 2023

Uh oh!

Trott commented Apr 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

TimothyGu commented Apr 5, 2023•
edited
Loading

nodejs-github-bot commented Apr 5, 2023•
edited by TimothyGu
Loading

Trott commented Apr 7, 2023•
edited
Loading