Skip to content

test: mark test-cluster-primary-error flaky on asan - #47422

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:make-cluster-flaky
Apr 14, 2023
Merged

test: mark test-cluster-primary-error flaky on asan#47422
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:make-cluster-flaky

Conversation

@anonrig

Copy link
Copy Markdown
Member

mitigation for #39655

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 5, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@richardlau

Copy link
Copy Markdown
Member

mitigation for #39655

AIX has nothing to do with the ASAN GitHub workflow.

@anonrig

Copy link
Copy Markdown
MemberAuthor

AIX has nothing to do with the ASAN GitHub workflow.

@richardlau I couldn't find any reference in the parallel.status for ASAN. Should I add a new section with [$system==asan]?

@richardlau

Copy link
Copy Markdown
Member

AIX has nothing to do with the ASAN GitHub workflow.

@richardlau I couldn't find any reference in the parallel.status for ASAN. Should I add a new section with [$system==asan]?

That probably won't work. System is from

node/tools/test.py

Lines 1671 to 1676 in ead4079

env= {
'mode': mode,
'system': utils.GuessOS(),
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
}
.

I have no idea how to represent ASAN builds in the status files.

@anonriganonrig added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 5, 2023
@Trott

Trott commented Apr 5, 2023

Copy link
Copy Markdown
Member

@anonrig You very well might already know this already, but just in case: ASan stands for "Address Sanitizer". More information is at https://clang.llvm.org/docs/AddressSanitizer.html. Hope that helps in figuring out either how to fix the text/issue or else how to detect ASan runs so things can be skipped if necessary.

Looking at https://github.com/nodejs/node/blob/ead407915e510014e5294dd4446e29d8f3f04bdc/.github/workflows/test-asan.yml, it seems an easy-ish way to detect an ASan build might be to check for --enable-asan in config.status.

@anonrig
anonrigforce-pushed the make-cluster-flaky branch 3 times, most recently from 1f8102d to d043490CompareApril 5, 2023 21:42
@anonriganonrig changed the title test: mark test-cluster-primary-error flaky on aixtest: mark test-cluster-primary-error flaky on asanApr 5, 2023
@anonrig
anonrigforce-pushed the make-cluster-flaky branch from d043490 to ac4d5f5CompareApril 5, 2023 21:42
@anonrig
anonrigforce-pushed the make-cluster-flaky branch from ac4d5f5 to 2d2934fCompareApril 13, 2023 21:06
@anonriganonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Apr 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonrig

Copy link
Copy Markdown
MemberAuthor

I fixed the issue. Appreciate if you can review this PR again...

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit c94be41 into nodejs:mainApr 14, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c94be41

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47422
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targostargos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47422
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47422
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@richardlau@Trott@jasnell@MoLow@VoltrexKeyva