Skip to content

test: mark test/parallel/test-file-write-stream4 as flaky - #47423

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-file-write-flaky
Apr 10, 2023
Merged

test: mark test/parallel/test-file-write-stream4 as flaky#47423
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:test-file-write-flaky

Conversation

@anonrig

@anonriganonrig commented Apr 5, 2023

Copy link
Copy Markdown
Member

a mitigation for #47420

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 5, 2023
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 5, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50974/

@anonrig
anonrig requested a review from richardlauApril 5, 2023 16:25
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50988/

richardlau
richardlau reviewed Apr 5, 2023
View reviewed changes
Comment threadtest/parallel/parallel.status Outdated
@anonrig
anonrigforce-pushed the test-file-write-flaky branch from 4db3e4d to 1ff9fecCompareApril 5, 2023 21:29
@anonrig
anonrig requested a review from richardlauApril 5, 2023 21:29
@anonrig
anonrigforce-pushed the test-file-write-flaky branch from 1ff9fec to 2b6588dCompareApril 5, 2023 21:30
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@gengjiawengengjiawen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 6, 2023
@github-actions

github-actionsBot commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @gengjiawen. Please 👍 to approve.

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/50995/

@targos

targos commented Apr 6, 2023

Copy link
Copy Markdown
Member

#47450 should make this unnecessary.

@anonrig

anonrig commented Apr 7, 2023

Copy link
Copy Markdown
MemberAuthor

The Github Workflow results are buggy again. Can someone land this manually?

@MoLow

MoLow commented Apr 7, 2023

Copy link
Copy Markdown
Member

@anonrig you can land manually as well. Run git node land 47423

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51054/

@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51071/

@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51081/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51090/

@TrottTrott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 08e1564 into nodejs:mainApr 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

Landed in 08e1564

@RafaelGSSRafaelGSS mentioned this pull request Apr 11, 2023
Merged
This was referenced Apr 12, 2023
Open
Open
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@anonrig@RafaelGSS
test: mark test/parallel/test-file-write-stream4 as flaky
a5a5d2f
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig@danielleadams
test: mark test/parallel/test-file-write-stream4 as flaky
17b5999
PR-URL: #47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig@MoLow
test: mark test/parallel/test-file-write-stream4 as flaky
914f68d
PR-URL: nodejs#47423
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@gengjiawengengjiawengengjiawen approved these changes
@richardlaurichardlaurichardlau approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@anonrig@nodejs-github-bot@targos@MoLow@Trott@gengjiawen@richardlau@VoltrexKeyva