Skip to content

tools: automate cjs-module-lexer dependency update - #47446

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/automate-cjs-module-lexer-update
Apr 9, 2023
Merged

tools: automate cjs-module-lexer dependency update#47446
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/automate-cjs-module-lexer-update

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Apr 6, 2023

Copy link
Copy Markdown
Member

Refs: nodejs/security-wg#828
@nodejs/security-wg

@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 6, 2023
debadree25
debadree25 reviewed Apr 6, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-cjs-module-lexer.sh Outdated
@marco-ippolitomarco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2023
ShogunPanda
ShogunPanda approved these changes Apr 7, 2023
View reviewed changes

@ShogunPandaShogunPanda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread.github/workflows/tools.yml Outdated

@ShogunPandaShogunPandaApr 7, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but I can't really say if you left this while debugging or it's actually needed. Just pointing this out for you to double check.

@marco-ippolitomarco-ippolitoApr 7, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debugging purposes we use it in every job

@richardlau

richardlau commented Apr 7, 2023

Copy link
Copy Markdown
Member

The script is missing this step to update the esm docs:

node/doc/contributing/maintaining-cjs-module-lexer.md

Lines 47 to 49 in 0c76922

* Update the link to the cjs-module-lexer in the list at the end of
[doc/api/esm.md](../api/esm.md)
to point to the updated version.

@richardlau

richardlau commented Apr 7, 2023

Copy link
Copy Markdown
Member

cc @guybedford

@marco-ippolito
marco-ippolitoforce-pushed the feat/automate-cjs-module-lexer-update branch from 1f9a35c to bf1e623CompareApril 8, 2023 10:03
@lpincalpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cfb654c into nodejs:mainApr 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in cfb654c

@RafaelGSSRafaelGSS mentioned this pull request Apr 11, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 13, 2023
@marco-ippolito@RafaelGSS
tools: automate cjs-module-lexer dependency update
37d1273
PR-URL: #47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
tniessen added a commit to tniessen/node that referenced this pull request Apr 24, 2023
@tniessen
tools: fix skip message in update-cjs-module-lexer
17035c7
Refs: nodejs#47446
@tniessentniessen mentioned this pull request Apr 24, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Apr 24, 2023
@tniessen
tools: fix skip message in update-cjs-module-lexer
8becacb
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@tniessen@targos
tools: fix skip message in update-cjs-module-lexer
d2994e5
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@marco-ippolito@danielleadams
tools: automate cjs-module-lexer dependency update
3717be7
PR-URL: #47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@tniessen@danielleadams
tools: fix skip message in update-cjs-module-lexer
b0134ee
Refs: #47446
PR-URL: #47701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@marco-ippolito@MoLow
tools: automate cjs-module-lexer dependency update
1271b0e
PR-URL: nodejs#47446
Refs: nodejs/security-wg#828
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@tniessen@MoLow
tools: fix skip message in update-cjs-module-lexer
64c3154
Refs: nodejs#47446
PR-URL: nodejs#47701
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPandaShogunPandaShogunPanda approved these changes
@guybedfordguybedfordguybedford approved these changes
@lpincalpincalpinca approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marco-ippolito@nodejs-github-bot@richardlau@ShogunPanda@guybedford@lpinca@debadree25@RafaelGSS