Uh oh!
There was an error while loading. Please reload this page.
doc,test: update the v8.startupSnapshot doc and test the example - #47468
Merged
Conversation
joyeecheung
marked this pull request as draft
April 7, 2023 13:59
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Apr 12, 2023
Collaborator
nodejs-github-bot
commented
Apr 12, 2023
Collaborator
36 tasks
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
nodejs-github-bot
commented
Apr 14, 2023
Collaborator
nodejs-github-bot
commented
Apr 14, 2023
Collaborator
33 tasks
joyeecheung
commented
Apr 24, 2023
MemberAuthor
ping @nodejs/documentation @nodejs/startup for a review |
Uh oh!
There was an error while loading. Please reload this page.
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite.
nodejs-github-bot
commented
May 2, 2023
Collaborator
legendecas
approved these changes
May 2, 2023
aymen94
approved these changes
May 3, 2023
nodejs-github-bot
commented
May 3, 2023
Collaborator
Landed in 2397585 |
targos pushed a commit
that referenced
this pull request
May 12, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: #47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit
that referenced
this pull request
Jul 6, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: #47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
The API is now available to user-land run-time snapshots. So update the example. This also makes the intention of the examples a bit clearer and test it in our test suite. PR-URL: nodejs#47468 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API is now available to user-land run-time snapshots. So update
the example. This also makes the intention of the examples a bit
clearer and test it in our test suite.
This depends on #47466 and #47467, otherwise the example is broken.