stream: emit .write() end error in next tick

[phillipj]

Next up in my TODO triaging, this time in _stream_writable.js.

Assuming it should be labelled semver-major as it changes from emitting error synchronously to async.

[evanlucas]

It would probably be better to just call process.nextTick once here and both emit the error and call the callback.

[mscdex]

I agree.

[phillipj]

It would probably be better to just call process.nextTick once here and both emit the error and call the callback.

Sure thing, agreed it looked strange. Just pushed an update.

[jasnell]

Generally LGTM once @evanlucas, @mscdex and CI are happy :-)

[evanlucas]

Marking as semver-major as it is a behavior change

[Fishrock123]

@nodejs/streams

[mafintosh]

i'm not sure we transform arrow functions yet in the readable-stream builds. @calvinmetcalf probably knows more about this?

[phillipj]

i'm not sure we transform arrow functions yet in the readable-stream builds.

I'll happily change it to an ordinary function. Really curious about what kind of transformation you're talking about though?

[mafintosh]

the readable-stream module is build from the node source using a couple of build methods, https://github.com/nodejs/readable-stream/tree/master/build to get better browser support.

[calvinmetcalf]

we do not support arrow functions at the moment, and it would be tricky to do so in a performant manner, that being said, you could change this code to be,

functionwriteAfterEnd(stream,cb){consterr=newError('write after end');stream.emit('error',err);cb(err);}

and then replace the use of writeAfterEndErr(this, cb) with

process.nextTick(writeAfterEnd,this,cb);

and this would avoid creating an unnecessary closure

[phillipj]

the readable-stream module is build from the node source using a couple of build methods, https://github.com/nodejs/readable-stream/tree/master/build to get better browser support.

Neat, that's some nice wizardry.

and then replace the use of writeAfterEndErr(this, cb) with

Thanks @calvinmetcalf, just pushed an update 👍

[chrisdickinson]

I worry about this a little, in that streams can be enormously fussy when it comes to when things happen. A CITGM run with this would ease my mind a bit (especially if CITGM contains stream-using packages, like gulp.)

[MylesBorins]

@chrisdickinson can you make a short list of stream based packages you would like to see added to citgm?

I'd be more than happy to add them then run the smoke-testing suite

[MylesBorins]

current lookup for reference --> https://github.com/nodejs/citgm/blob/master/lib/lookup.json

[phillipj]

I just created these citgm reports @chrisdickinson:

This PR

Flaky Modules

• express
  • version 4.13.3
  • Error: The canary is dead.
• react
  • version 0.14.6
  • Error: Install Failed

v4.2.5

Flaky Modules

• express
  • version 4.13.3
  • Error: The canary is dead.

v5.5.0

Flaky Modules

• express
  • version 4.13.3
  • Error: The canary is dead.
• socket.io
  • version 1.4.4
  • Error: The canary is dead.
• react
  • version 0.14.6
  • Error: Install Failed

P.S. react fails deliberately as it requires v4.x obviously.

[jasnell]

Unfortunately I think failures on those in citgm are common. @thealphanerd can say for sure tho

[MylesBorins]

Those are all expected 😄

[MylesBorins]

fwiw I think @chrisdickinson wanted to add more modules to citgm that were focused on streams.

[chrisdickinson]

I might see if @phated can recommend some modules from the Gulp ecosystem.

[phated]

@chrisdickinson what are you looking for?

[jasnell]

@phated ... we'd like to get a handful of stream-related modules to add to our smoke-testing infrastructure (http://github.com/nodejs/citgm). We run the tests for every new release and to get an idea of whether a particular change will break the ecosystem.

[phated]

vinyl, vinyl-fs, probably something like gulp-jade or other popular plugins (I don't have actual numbers on any of that)

The most important one is probably vinyl-fs which will be receiving even more tests coming up very soon.

[jasnell]

@phated... excellent. /cc @thealphanerd

[MylesBorins]

I've opened a PR adding vinyl, vinyl-fs, and readable-stream to citgm.

I'm open to other suggestions

nodejs/citgm#68

[phillipj]

Updated results after mentioned updates to citgm ^^

Flaky Modules

• socket.io
  • version 1.4.5
  • Error: The canary is dead.
• react
  • version 0.14.7
  • Error: Install Failed
• spdy
  • version 3.2.0
  • Error: The canary is dead.

Identical results ran on master and this branch/PR, in other words doesn't seem like this PR introduces more failures..

@thealphanerd is the spdy failure expected?

[jasnell]

FWIW, still LGTM /cc @nodejs/ctc

[jasnell]

Actually.. looks like this change is also applied in #5251 ... may be able to close this in favor of that one

[phillipj]

Yep, surely looks like we've done some duplicate work on this one. As #5251 fixes alot more of these issues, I'll close this one and re-open if the other one doesn't land.