Skip to content

quic: add more QUIC implementation - #47494

Closed
jasnell wants to merge 9 commits into
nodejs:mainfrom
jasnell:quic-part-4
Closed

quic: add more QUIC implementation#47494
jasnell wants to merge 9 commits into
nodejs:mainfrom
jasnell:quic-part-4

Conversation

@jasnell

@jasnelljasnell commented Apr 10, 2023

Copy link
Copy Markdown
Member

More implementation details...

@jasnell
jasnell requested review from anonrig and tniessenApril 10, 2023 02:47
@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 10, 2023
VoltrexKeyva
VoltrexKeyva reviewed Apr 10, 2023
View reviewed changes
Comment threadsrc/quic/bindingdata.cc Outdated
Comment threadsrc/quic/bindingdata.cc Outdated
Comment threadsrc/quic/defs.h Outdated
Comment threadsrc/quic/packet.cc Outdated
Comment threadsrc/quic/packet.cc
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Apr 12, 2023
Open
Open
tniessen
tniessen reviewed Apr 14, 2023
View reviewed changes

@tniessentniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are relevant test failures AFAICT.

Comment threadsrc/quic/tlscontext.h
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 15, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2023•
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51324/ 💛

@github-actionsgithub-actionsBot mentioned this pull request Apr 18, 2023
Open
35 tasks
jasnell added a commit that referenced this pull request Apr 18, 2023
@jasnell
quic: add more QUIC implementation
1c3d741
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope
PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@jasnell

jasnell commented Apr 18, 2023

Copy link
Copy Markdown
MemberAuthor

Landed in 1c3d741

@jasnelljasnell closed this Apr 18, 2023
targos pushed a commit that referenced this pull request May 2, 2023
@jasnell@targos
quic: add more QUIC implementation
e8ea834
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope
PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@jasnell@danielleadams
quic: add more QUIC implementation
1efa62e
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope
PR-URL: #47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@jasnell@MoLow
quic: add more QUIC implementation
75d7024
* add TLSContext
* quic: add stat collection utilities
* add Packet
* add NgTcp2CallbackScope/NgHttp3CallbackScope
PR-URL: nodejs#47494
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonriganonriganonrig approved these changes
@tniessentniessentniessen approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@nodejs-github-bot@anonrig@tniessen@VoltrexKeyva