Skip to content

tools: automate uvwasi dependency update - #47509

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ranieri93:feat/automate-uvwasi-update
Apr 13, 2023
Merged

tools: automate uvwasi dependency update#47509
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Ranieri93:feat/automate-uvwasi-update

Conversation

@Ranieri93

@Ranieri93Ranieri93 commented Apr 11, 2023

Copy link
Copy Markdown
Contributor

@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-botnodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Apr 11, 2023
@Ranieri93
Ranieri93 marked this pull request as ready for review April 11, 2023 15:03
mhdawson
mhdawson reviewed Apr 11, 2023
View reviewed changes
Comment threadtools/dep_updaters/update-uvwasi.sh Outdated
mhdawson
mhdawson reviewed Apr 11, 2023
View reviewed changes
Comment threaddoc/contributing/maintaining-web-assembly.md Outdated

@mhdawsonmhdawsonApr 11, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to check this in the update script and to generate a warning/info message if there are new files found?

@Ranieri93Ranieri93Apr 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a valid point, maybe @marco-ippolito already faced something alike in other scripts, I'll ask him!

@marco-ippolitomarco-ippolitoApr 12, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the first attempt of automating gyp file update #47482, let's see how it goes and if its reliable we can add it to other dependencies.
For the time being I'd add a warn like:
echo "Make sure to update the deps/uvwasi/uvwasi.gyp if any significant changes have occurred upstream" in the bash script

marco-ippolito
marco-ippolito approved these changes Apr 12, 2023
View reviewed changes

@marco-ippolitomarco-ippolito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson
mhdawson approved these changes Apr 13, 2023
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS

RafaelGSS commented Apr 13, 2023

Copy link
Copy Markdown
Member

cc: @nodejs/security-wg

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5fa84e8 into nodejs:mainApr 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5fa84e8

targos pushed a commit that referenced this pull request May 2, 2023
@Ranieri93@targos
tools: automate uvwasi dependency update
9e3e0b0
Refs: nodejs/security-wg#828
PR-URL: #47509
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@Ranieri93@danielleadams
tools: automate uvwasi dependency update
cacd424
Refs: nodejs/security-wg#828
PR-URL: #47509
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@Ranieri93@MoLow
tools: automate uvwasi dependency update
c522762
Refs: nodejs/security-wg#828
PR-URL: nodejs#47509
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelGSSRafaelGSSRafaelGSS approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Ranieri93@nodejs-github-bot@RafaelGSS@mhdawson@marco-ippolito