Skip to content

doc: fix release-post script location - #47517

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-release-blog-script-location
Apr 17, 2023
Merged

doc: fix release-post script location#47517
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-release-blog-script-location

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

The release-post script now is in a different location and should be called directly with node

cc: @nodejs/releasers

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 11, 2023
Comment threaddoc/contributing/releases.md Outdated
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS
RafaelGSSforce-pushed the fix-release-blog-script-location branch from 7b32e0e to 99b767dCompareApril 12, 2023 12:56
release. However, the blog post is not yet fully automatic.

Create a new blog post by running the [nodejs.org release-post.js script][].
Create a new blog post by running the [nodejs.org release-post.js script][]:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link name (release-post.js script) should also be changed.

@RafaelGSSRafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 17, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 17c9aa2 into nodejs:mainApr 17, 2023
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 17c9aa2

targos pushed a commit that referenced this pull request May 2, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #47517
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targostargos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: #47517
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#47517
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

11 participants

@RafaelGSS@nodejs-github-bot@ruyadorno@lpinca@targos@tniessen@richardlau@danielleadams@BethGriggs@aymen94@HarshithaKP