Uh oh!
There was an error while loading. Please reload this page.
deps: patch V8 to 11.3.244.8 - #47536
Merged
Merged
Conversation
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
Review requested:
|
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
aduh95
approved these changes
Apr 13, 2023
| Today's answer to life the universe and everything is 6728!! | ||
| Off-course, this is wrong ... | ||
| .. | ||
| What's a fish without eyes? A fsh! |
richardlau
approved these changes
Apr 13, 2023
richardlau
commented
Apr 13, 2023
Member
I'm not sure if the 11:40:33 not ok 2 v8-updates/test-linux-perf11:40:33 ---11:40:33 duration_ms: 2317.6820011:40:33 severity: fail11:40:33 exitcode: 111:40:33 stack: |-11:40:33 node:assert:39911:40:33 throw err;11:40:33 ^11:40:33 11:40:33 AssertionError [ERR_ASSERTION]: Couldn't find interpreted functionOne() |
targos
commented
Apr 13, 2023
MemberAuthor
I've certainly seen this failure before, so probably a flake. |
gengjiawen
approved these changes
Apr 13, 2023
nodejs-github-bot
commented
Apr 13, 2023
Collaborator
nodejs-github-bot
commented
Apr 14, 2023
Collaborator
nodejs-github-bot
commented
Apr 14, 2023
Collaborator
33 tasks
nodejs-github-bot
commented
Apr 17, 2023
Collaborator
Landed in b8c7a1e |
35 tasks
targos added a commit
that referenced
this pull request
May 2, 2023
Refs: v8/v8@11.3.244.4...11.3.244.8 PR-URL: #47536 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: v8/v8@11.3.244.4...11.3.244.8