Skip to content

benchmark: add a benchmark for defaultResolve - #47543

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:bench-resolve
Apr 13, 2023
Merged

benchmark: add a benchmark for defaultResolve#47543
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:bench-resolve

Conversation

@aduh95

@aduh95aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2023
@github-actions

github-actionsBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
@aduh95aduh95 mentioned this pull request Apr 13, 2023
Merged
@anonriganonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@aduh95

aduh95 commented Apr 13, 2023

Copy link
Copy Markdown
ContributorAuthor

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1325/

@anonriganonrig added the performance Issues and PRs related to the performance of Node.js. label Apr 13, 2023
VoltrexKeyva
VoltrexKeyva reviewed Apr 13, 2023
View reviewed changes
Comment threadbenchmark/esm/esm-loader-defaultResolve.js Outdated
GeoffreyBooth
GeoffreyBooth reviewed Apr 13, 2023
View reviewed changes
Comment threadbenchmark/esm/esm-loader-defaultResolve.js Outdated
Comment threadbenchmark/esm/esm-loader-defaultResolve.js Outdated
@aduh95@VoltrexKeyva@GeoffreyBooth
Apply suggestions from code review
7899655
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
@GeoffreyBoothGeoffreyBooth removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@anonriganonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 13, 2023
JakobJingleheimer
JakobJingleheimer approved these changes Apr 13, 2023
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4afb25c into nodejs:mainApr 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4afb25c

@aduh95
aduh95 deleted the bench-resolve branch April 13, 2023 20:05
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95@targos
benchmark: add a benchmark for defaultResolve
936d7cb
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@aduh95@danielleadams
benchmark: add a benchmark for defaultResolve
fbce3b9
PR-URL: #47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@aduh95@MoLow
benchmark: add a benchmark for defaultResolve
d8233d9
PR-URL: nodejs#47543
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@danielleadamsdanielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@anonriganonriganonrig approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes
+1 more reviewer
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.performanceIssues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@anonrig@JakobJingleheimer@VoltrexKeyva