Skip to content

url: handle URL.canParse without base parameter - #47547

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-url-can-parse
Apr 14, 2023
Merged

url: handle URL.canParse without base parameter#47547
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:fix-url-can-parse

Conversation

@anonrig

@anonriganonrig commented Apr 13, 2023

Copy link
Copy Markdown
Member

Fixes the bug caught by this pull request: #47541

Requesting fast-track to unblock the parent pull request.

cc @nodejs/url

@anonriganonrig added whatwg-url Issues and PRs related to the WHATWG URL implementation. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

@github-actions

github-actionsBot commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. string_decoder Issues and PRs related to the string_decoder subsystem. labels Apr 13, 2023
@anonriganonrig removed the string_decoder Issues and PRs related to the string_decoder subsystem. label Apr 13, 2023
@debadree25debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 13, 2023
KhafraDev
KhafraDev approved these changes Apr 13, 2023
View reviewed changes

@KhafraDevKhafraDev left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonriganonrig removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@anonrig

anonrig commented Apr 13, 2023

Copy link
Copy Markdown
MemberAuthor

I'm updating the test to also include internalBinding call.

@anonriganonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51206/

@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51213/

@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51223/

@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51233/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 3d17735 into nodejs:mainApr 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3d17735

@github-actionsgithub-actionsBot mentioned this pull request Apr 15, 2023
Open
33 tasks
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig@targos
url: handle URL.canParse without base parameter
9aae767
PR-URL: #47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request May 2, 2023
Merged
@anonriganonrig mentioned this pull request Jun 17, 2023
Closed
19 tasks
anonrig added a commit to anonrig/node that referenced this pull request Jul 9, 2023
@anonrig
url: handle URL.canParse without base parameter
5824a9e
PR-URL: nodejs#47547
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 12, 2023
@anonrig@danielleadams
url: handle URL.canParse without base parameter
8897305
PR-URL: #47547
Backport-PR-URL: #48345
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadamsdanielleadams mentioned this pull request Jul 12, 2023
Merged
@merceyzmerceyz mentioned this pull request Feb 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@ronagronagronag approved these changes
@KhafraDevKhafraDevKhafraDev approved these changes
+1 more reviewer
@debadree25debadree25debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.whatwg-urlIssues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@lpinca@ronag@debadree25@KhafraDev@danielleadams