Skip to content

esm: propagate process.exit from the loader thread to the main thread - #47548

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:process-exit-loader
Apr 19, 2023
Merged

esm: propagate process.exit from the loader thread to the main thread#47548
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:process-exit-loader

Conversation

@aduh95

@aduh95aduh95 commented Apr 13, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Calling process.exit from the loader used to exit the process, but now that loader code is executed on a different thread, we need to pass the information across thread to avoid leaving the main thread without a loader thread.

@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Apr 13, 2023
GeoffreyBooth
GeoffreyBooth reviewed Apr 13, 2023
View reviewed changes
Comment threadlib/internal/modules/esm/hooks.js Outdated
@aduh95
aduh95 marked this pull request as ready for review April 14, 2023 09:53
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 14, 2023
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51259/

@github-actionsgithub-actionsBot mentioned this pull request Apr 15, 2023
Open
33 tasks
JakobJingleheimer
JakobJingleheimer approved these changes Apr 15, 2023
View reviewed changes

@JakobJingleheimerJakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51290/

@nodejs-github-bot

nodejs-github-bot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51294/

@nodejs-github-bot

nodejs-github-bot commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51310/

@github-actionsgithub-actionsBot mentioned this pull request Apr 18, 2023
Open
35 tasks
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51338/

@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51346/

@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51350/

@GeoffreyBoothGeoffreyBooth added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 19, 2023
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 2e0152c into nodejs:mainApr 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in 2e0152c

@aduh95
aduh95 deleted the process-exit-loader branch April 19, 2023 07:40
@github-actionsgithub-actionsBot mentioned this pull request Apr 24, 2023
Open
39 tasks
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95@targos
esm: propagate process.exit from the loader thread to the main thread
55f70f6
PR-URL: #47548
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request May 2, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95@targos
esm: propagate process.exit from the loader thread to the main thread
4990269
PR-URL: nodejs#47548
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95@targos
esm: propagate process.exit from the loader thread to the main thread
39fbce7
PR-URL: #47548
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@targostargos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: propagate process.exit from the loader thread to the
a41f3e8
PR-URL: nodejs/node#47548
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
esm: propagate process.exit from the loader thread to the
ea20e5d
PR-URL: nodejs/node#47548
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@JakobJingleheimerJakobJingleheimerJakobJingleheimer approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.esmIssues and PRs related to the ECMAScript Modules implementation.

Projects

None yet

Milestone

ESM Loaders: Stable (CJS parity)

Development

Successfully merging this pull request may close these issues.

6 participants

@aduh95@nodejs-github-bot@GeoffreyBooth@JakobJingleheimer@targos@danielleadams