Skip to content

doc: fix split infinitive in Hooks caveat - #47550

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
JakobJingleheimer:esm/correct-split-infinitive-in-doc
Apr 13, 2023
Merged

doc: fix split infinitive in Hooks caveat#47550
aduh95 merged 1 commit into
nodejs:mainfrom
JakobJingleheimer:esm/correct-split-infinitive-in-doc

Conversation

@JakobJingleheimer

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 13, 2023
@aduh95aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 13, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95aduh95 changed the title esm: correct split infinitive in Hooks caveatdoc: unsplit infinitive in Hooks caveatApr 13, 2023
@aduh95aduh95 changed the title doc: unsplit infinitive in Hooks caveatdoc: fix split infinitive in Hooks caveatApr 13, 2023
@aduh95
aduh95 merged commit 1c3cbf3 into nodejs:mainApr 13, 2023
@aduh95

Copy link
Copy Markdown
Contributor

Landed in 1c3cbf3

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47550
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targostargos mentioned this pull request May 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@JakobJingleheimer@nodejs-github-bot@aduh95@GeoffreyBooth@MoLow@targos@danielleadams